test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Qiu, Michael" <michael.qiu@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [dts] [PATCH] test_plan: add hotplug_test_plan
Date: Tue, 10 Feb 2015 08:54:47 +0000	[thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286CE7941@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <54D979EA.6010403@igel.co.jp>

On 2/10/2015 11:24 AM, Tetsuya Mukawa wrote:
> Hi Michael,
>
> On 2015/02/09 22:13, Qiu, Michael wrote:
>> [+cc] Bernard
>>
>> Hi, Bernard and Tetsuya
>>
>> Would you have time to review this test plan?
>> Your comments are very important.
>>
>> Thanks,
>> Michael
>> On 2/2/2015 4:47 PM, Qiu, Michael wrote:

[...]

>> +
>> +Prerequisites
>> +-------------
>> +Assume DPDK managerd at least one device for physical or none for virtual.
> "managerd" may be typo.
>
>>> +This feature only supports igb_uio now, for uio_pci_generic is
>>> +on the way, will test it after enabled.
>>> +
>>> +To run the testpmd application in linuxapp environment with 4 lcores,
>>> +4 channels with other default parameters in interactive mode.
>>> +
>>> +        $ ./testpmd -c 0xf -n 4 -- -i
>>> +
>>> +Test ENV:
>>> +
>>> +All test case can be run in 32bit and 64bit platform.
>>> +
>>> +All os can be support, like fedora, ubuntu, rhel, suse, but freebsd will
>>> +not include as hotplug has no plan to support that platform
>>> +
>>> +All kernel version(start from 2.6) can be support, for vfio need kernel
>>> +        version greater than 3.6.
>>> +
>>> +Virtulization support: KVM/VMware/Xen, container is in the roadmap
> "Virtulization" may be typo.
>
>>> +
>>> +-------------------------------------------------------------------------------
>>> +Test Case 1: port dettach & attach for physical devices with igb_uio
>>> +-------------------------------------------------------------------------------
>>> +1. run "port attach 0000:02:00.0",
>>> +   assume the physical devices is BDF is 0000:02:00.0
> Above sentence may be typo.

[...]

> Usually before submitting hotplug patches, I test almost same as above,
> and additionally below cases.
>
> ---------------------------
> Test Re-attach
> ---------------------------
>   - testpmd> attach
>  - testpmd> port start
>  - testpmd> start
>  - testpmd> stop
>  - testpmd> port stop
>  - testpmd> port close
>  - testpmd> port detach
>  - testpmd> port attach
>  - testpmd> port start
>  - testpmd> start
>  - testpmd> stop
>   (To check if re-attached port works fine.)

This will be added for every test case

> ---------------------------
> start testpmd with "--vdev" option, and detach.
> ---------------------------
>
>   - ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=<interface>" -- -i
>  - testpmd> start
>  - testpmd> stop
>  - testpmd> port stop
>  - testpmd> port close
>  - testpmd> port detach
>    (To make sure if we can detach the port)
>
> ---------------------------
> start testpmd with an attached physical NIC port, and detach.
> ---------------------------
>   - ./dpdk_nic_bind -b igb_uio <pci address>
>  - ./testpmd -c 0xf -n 4 -- -i
>  - testpmd> start
>  - testpmd> stop
>  - testpmd> port stop
>  - testpmd> port close
>  - testpmd> port detach
>    (To make sure if we can detach the port)

I will add both.

Thanks,
Michael
> How about adding such cases?
>
> Thanks,
> Tetsuya
>
>
>
>
>
>


  parent reply	other threads:[~2015-02-10  8:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1422866813-23729-1-git-send-email-michael.qiu@intel.com>
2015-02-09 13:13 ` Qiu, Michael
2015-02-09 16:26   ` Iremonger, Bernard
2015-02-10  6:10     ` Qiu, Michael
     [not found]   ` <54D979EA.6010403@igel.co.jp>
2015-02-10  8:54     ` Qiu, Michael [this message]
2015-02-10 16:54       ` Iremonger, Bernard
2015-02-11  2:33         ` Tetsuya Mukawa
2015-02-11  2:38           ` Qiu, Michael
2015-03-04  2:53 ` [dts] [PATCH v2] " Michael Qiu
2015-04-28  9:08   ` Qiu, Michael
2015-04-28  9:32     ` Liu, Yong
2015-04-28  9:34       ` Qiu, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533710CFB86FA344BFBF2D6802E60286CE7941@SHSMSX101.ccr.corp.intel.com \
    --to=michael.qiu@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dts@dpdk.org \
    --cc=mukawa@igel.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).