From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 85B593208 for ; Wed, 11 Feb 2015 03:40:27 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 10 Feb 2015 18:40:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,554,1418112000"; d="scan'208";a="664622070" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by fmsmga001.fm.intel.com with ESMTP; 10 Feb 2015 18:40:25 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 11 Feb 2015 10:38:20 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.192]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.209]) with mapi id 14.03.0195.001; Wed, 11 Feb 2015 10:38:19 +0800 From: "Qiu, Michael" To: Tetsuya Mukawa , "Iremonger, Bernard" , "dts@dpdk.org" Thread-Topic: [PATCH] test_plan: add hotplug_test_plan Thread-Index: AQHQPsTXSPmZsjvrL02oMBr5A1mZQw== Date: Wed, 11 Feb 2015 02:38:18 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CE7CD1@SHSMSX101.ccr.corp.intel.com> References: <1422866813-23729-1-git-send-email-michael.qiu@intel.com> <533710CFB86FA344BFBF2D6802E60286CE7206@SHSMSX101.ccr.corp.intel.com> <54D979EA.6010403@igel.co.jp> <533710CFB86FA344BFBF2D6802E60286CE7941@SHSMSX101.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C2049DF61E@IRSMSX108.ger.corp.intel.com> <54DABF7C.8090804@igel.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] test_plan: add hotplug_test_plan X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 02:40:28 -0000 On 2/11/2015 10:33 AM, Tetsuya Mukawa wrote:=0A= > On 2015/02/11 1:54, Iremonger, Bernard wrote:=0A= >>> -----Original Message-----=0A= >>> From: Qiu, Michael=0A= >>> Sent: Tuesday, February 10, 2015 8:55 AM=0A= >>> To: Tetsuya Mukawa; dts@dpdk.org=0A= >>> Cc: Iremonger, Bernard=0A= >>> Subject: Re: [PATCH] test_plan: add hotplug_test_plan=0A= >>>=0A= >>> On 2/10/2015 11:24 AM, Tetsuya Mukawa wrote:=0A= >>>> Hi Michael,=0A= >>>>=0A= >>>> On 2015/02/09 22:13, Qiu, Michael wrote:=0A= >>>>> [+cc] Bernard=0A= >>>>>=0A= >>>>> Hi, Bernard and Tetsuya=0A= >>>>>=0A= >>>>> Would you have time to review this test plan?=0A= >>>>> Your comments are very important.=0A= >>>>>=0A= >>>>> Thanks,=0A= >>>>> Michael=0A= >>>>> On 2/2/2015 4:47 PM, Qiu, Michael wrote:=0A= >>> [...]=0A= >>>=0A= >>>>> +=0A= >>>>> +Prerequisites=0A= >>>>> +-------------=0A= >>>>> +Assume DPDK managerd at least one device for physical or none for vi= rtual.=0A= >>>> "managerd" may be typo.=0A= >>>>=0A= >>>>>> +This feature only supports igb_uio now, for uio_pci_generic is on= =0A= >>>>>> +the way, will test it after enabled.=0A= >>>>>> +=0A= >>>>>> +To run the testpmd application in linuxapp environment with 4=0A= >>>>>> +lcores,=0A= >>>>>> +4 channels with other default parameters in interactive mode.=0A= >>>>>> +=0A= >>>>>> + $ ./testpmd -c 0xf -n 4 -- -i=0A= >>>>>> +=0A= >>>>>> +Test ENV:=0A= >>>>>> +=0A= >>>>>> +All test case can be run in 32bit and 64bit platform.=0A= >>>>>> +=0A= >>>>>> +All os can be support, like fedora, ubuntu, rhel, suse, but freebsd= =0A= >>>>>> +will not include as hotplug has no plan to support that platform=0A= >>>>>> +=0A= >>>>>> +All kernel version(start from 2.6) can be support, for vfio need ke= rnel=0A= >>>>>> + version greater than 3.6.=0A= >>>>>> +=0A= >>>>>> +Virtulization support: KVM/VMware/Xen, container is in the roadmap= =0A= >>>> "Virtulization" may be typo.=0A= >>>>=0A= >>>>>> +=0A= >>>>>> +-------------------------------------------------------------------= =0A= >>>>>> +------------ Test Case 1: port dettach & attach for physical=0A= >>>>>> +devices with igb_uio=0A= >>>>>> +-------------------------------------------------------------------= =0A= >>>>>> +------------=0A= >>>>>> +1. run "port attach 0000:02:00.0",=0A= >>>>>> + assume the physical devices is BDF is 0000:02:00.0=0A= >>>> Above sentence may be typo.=0A= >>> [...]=0A= >>>=0A= >>>> Usually before submitting hotplug patches, I test almost same as=0A= >>>> above, and additionally below cases.=0A= >>>>=0A= >>>> ---------------------------=0A= >>>> Test Re-attach=0A= >>>> ---------------------------=0A= >>>> - testpmd> attach=0A= >>>> - testpmd> port start=0A= >>>> - testpmd> start=0A= >>>> - testpmd> stop=0A= >>>> - testpmd> port stop=0A= >>>> - testpmd> port close=0A= >>>> - testpmd> port detach=0A= >>>> - testpmd> port attach=0A= >>>> - testpmd> port start=0A= >>>> - testpmd> start=0A= >>>> - testpmd> stop=0A= >>>> (To check if re-attached port works fine.)=0A= >>> This will be added for every test case=0A= >>>=0A= >>>> ---------------------------=0A= >>>> start testpmd with "--vdev" option, and detach.=0A= >>>> ---------------------------=0A= >>>>=0A= >>>> - ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=3D" -- -i= =0A= >>>> - testpmd> start=0A= >>>> - testpmd> stop=0A= >>>> - testpmd> port stop=0A= >>>> - testpmd> port close=0A= >>>> - testpmd> port detach=0A= >>>> (To make sure if we can detach the port)=0A= >>>>=0A= >>>> ---------------------------=0A= >>>> start testpmd with an attached physical NIC port, and detach.=0A= >>>> ---------------------------=0A= >>>> - ./dpdk_nic_bind -b igb_uio =0A= >>>> - ./testpmd -c 0xf -n 4 -- -i=0A= >>>> - testpmd> start=0A= >>>> - testpmd> stop=0A= >>>> - testpmd> port stop=0A= >>>> - testpmd> port close=0A= >>>> - testpmd> port detach=0A= >>>> (To make sure if we can detach the port)=0A= >>> I will add both.=0A= >>>=0A= >>> Thanks,=0A= >>> Michael=0A= >>>> How about adding such cases?=0A= >>>>=0A= >>>> Thanks,=0A= >>>> Tetsuya=0A= >>>>=0A= >>>>=0A= >> Hi Michael, Tetsuya,=0A= >>=0A= >> Should there be test cases added using pmd_null (eth_null0) ?=0A= > Hi Bernard,=0A= >=0A= > I guess port hotplug function can be separated in below 2 implementations= .=0A= > - port hotplug framework=0A= > - port hotplug implementation in each PMD.=0A= >=0A= > This test plan is for checking hotplug framework.=0A= > So I guess we don't need to add Null pmd cases.=0A= =0A= Agree, DTS do not care PMD, it care about different NICs, for DPDK, it=0A= chose PMD for different NICs=0A= =0A= Thanks,=0A= Michael=0A= > When DTS has tests for each PMD, I guess each PMD tests should have=0A= > cases for hotplug, because each PMD will have different implementation=0A= > for hotplug. I guess null pmd should be also checked like this.=0A= >=0A= > Anyway, if we are not so hurry about adding null pmd tests, I guess I=0A= > will be able to commit it next month.=0A= >=0A= > Thanks,=0A= > Tetsuya=0A= >=0A= >> Regards,=0A= >>=0A= >> Bernard.=0A= >>=0A= >>=0A= >=0A= >=0A= =0A=