From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 6E0505A44 for ; Wed, 11 Feb 2015 03:33:38 +0100 (CET) Received: by pdjy10 with SMTP id y10so957222pdj.13 for ; Tue, 10 Feb 2015 18:33:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=RGzDo+gT+Gr5NElXAjTyzLK2KiGr6Gft6t11wkuTJc0=; b=dkor5MvMNiSvku4bvvTMLAeI7GEzzRXjfzPhWP2Q93ve0G0+GmBqQzf0TUvpeOQZv8 Xt3WjePEyB28/9ii8UFZ01F1xPOv6BSyB0T+kXYPAMyLQOFg7kVIZqE/Sh71Vq3Vaio+ hgKZVYr//AOPeKaseH2G49QFxoRewHvv+HISrCZKlEy7Szd3BXF6FUjOr3oaREQ26Xs2 H5x+tZt0T/Z6ziBAZM3uhe0qfTsPBWBx/AYY+FbuEkvW5UYjVNfxdzzY3bqEvJDqgwXA +Bq/ttLj61ER8QYYB95vZY25qQ8U19DRDPijNQovrsW4cbZml04b/NR2NfpbkvknKsU/ IU6A== X-Gm-Message-State: ALoCoQnnlYIfe4sj+UTIzHDhCnv4HUaOJjvu2Nqv/V8Lh+f2j9ji2lYOmF/0yKFQwvs4mjsAkDcB X-Received: by 10.67.6.103 with SMTP id ct7mr43300144pad.49.1423622017730; Tue, 10 Feb 2015 18:33:37 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id rd10sm9584893pdb.76.2015.02.10.18.33.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Feb 2015 18:33:37 -0800 (PST) Message-ID: <54DABF7C.8090804@igel.co.jp> Date: Wed, 11 Feb 2015 11:33:32 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Iremonger, Bernard" , "Qiu, Michael" , "dts@dpdk.org" References: <1422866813-23729-1-git-send-email-michael.qiu@intel.com> <533710CFB86FA344BFBF2D6802E60286CE7206@SHSMSX101.ccr.corp.intel.com> <54D979EA.6010403@igel.co.jp> <533710CFB86FA344BFBF2D6802E60286CE7941@SHSMSX101.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C2049DF61E@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C2049DF61E@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dts] [PATCH] test_plan: add hotplug_test_plan X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 02:33:38 -0000 On 2015/02/11 1:54, Iremonger, Bernard wrote: > >> -----Original Message----- >> From: Qiu, Michael >> Sent: Tuesday, February 10, 2015 8:55 AM >> To: Tetsuya Mukawa; dts@dpdk.org >> Cc: Iremonger, Bernard >> Subject: Re: [PATCH] test_plan: add hotplug_test_plan >> >> On 2/10/2015 11:24 AM, Tetsuya Mukawa wrote: >>> Hi Michael, >>> >>> On 2015/02/09 22:13, Qiu, Michael wrote: >>>> [+cc] Bernard >>>> >>>> Hi, Bernard and Tetsuya >>>> >>>> Would you have time to review this test plan? >>>> Your comments are very important. >>>> >>>> Thanks, >>>> Michael >>>> On 2/2/2015 4:47 PM, Qiu, Michael wrote: >> [...] >> >>>> + >>>> +Prerequisites >>>> +------------- >>>> +Assume DPDK managerd at least one device for physical or none for v= irtual. >>> "managerd" may be typo. >>> >>>>> +This feature only supports igb_uio now, for uio_pci_generic is on >>>>> +the way, will test it after enabled. >>>>> + >>>>> +To run the testpmd application in linuxapp environment with 4 >>>>> +lcores, >>>>> +4 channels with other default parameters in interactive mode. >>>>> + >>>>> + $ ./testpmd -c 0xf -n 4 -- -i >>>>> + >>>>> +Test ENV: >>>>> + >>>>> +All test case can be run in 32bit and 64bit platform. >>>>> + >>>>> +All os can be support, like fedora, ubuntu, rhel, suse, but freebs= d >>>>> +will not include as hotplug has no plan to support that platform >>>>> + >>>>> +All kernel version(start from 2.6) can be support, for vfio need k= ernel >>>>> + version greater than 3.6. >>>>> + >>>>> +Virtulization support: KVM/VMware/Xen, container is in the roadmap= >>> "Virtulization" may be typo. >>> >>>>> + >>>>> +------------------------------------------------------------------= - >>>>> +------------ Test Case 1: port dettach & attach for physical >>>>> +devices with igb_uio >>>>> +------------------------------------------------------------------= - >>>>> +------------ >>>>> +1. run "port attach 0000:02:00.0", >>>>> + assume the physical devices is BDF is 0000:02:00.0 >>> Above sentence may be typo. >> [...] >> >>> Usually before submitting hotplug patches, I test almost same as >>> above, and additionally below cases. >>> >>> --------------------------- >>> Test Re-attach >>> --------------------------- >>> - testpmd> attach >>> - testpmd> port start >>> - testpmd> start >>> - testpmd> stop >>> - testpmd> port stop >>> - testpmd> port close >>> - testpmd> port detach >>> - testpmd> port attach >>> - testpmd> port start >>> - testpmd> start >>> - testpmd> stop >>> (To check if re-attached port works fine.) >> This will be added for every test case >> >>> --------------------------- >>> start testpmd with "--vdev" option, and detach. >>> --------------------------- >>> >>> - ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=3D" -- -= i >>> - testpmd> start >>> - testpmd> stop >>> - testpmd> port stop >>> - testpmd> port close >>> - testpmd> port detach >>> (To make sure if we can detach the port) >>> >>> --------------------------- >>> start testpmd with an attached physical NIC port, and detach. >>> --------------------------- >>> - ./dpdk_nic_bind -b igb_uio >>> - ./testpmd -c 0xf -n 4 -- -i >>> - testpmd> start >>> - testpmd> stop >>> - testpmd> port stop >>> - testpmd> port close >>> - testpmd> port detach >>> (To make sure if we can detach the port) >> I will add both. >> >> Thanks, >> Michael >>> How about adding such cases? >>> >>> Thanks, >>> Tetsuya >>> >>> > Hi Michael, Tetsuya, > > Should there be test cases added using pmd_null (eth_null0) ? Hi Bernard, I guess port hotplug function can be separated in below 2 implementations= =2E - port hotplug framework - port hotplug implementation in each PMD. This test plan is for checking hotplug framework. So I guess we don't need to add Null pmd cases. When DTS has tests for each PMD, I guess each PMD tests should have cases for hotplug, because each PMD will have different implementation for hotplug. I guess null pmd should be also checked like this. Anyway, if we are not so hurry about adding null pmd tests, I guess I will be able to commit it next month. Thanks, Tetsuya > Regards, > > Bernard. > >