test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Michael Qiu <michael.qiu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH] pmdrssreta: Add RRC support in TestSuite pmdrssreta
Date: Thu, 22 Oct 2015 15:45:16 +0800	[thread overview]
Message-ID: <5628940C.3090003@intel.com> (raw)
In-Reply-To: <1444719518-32639-1-git-send-email-michael.qiu@intel.com>

Applied. Thx.

On 10/13/2015 02:58 PM, Michael Qiu wrote:
>   RRC support in TestSuite pmdrssreta.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
>   tests/TestSuite_pmdrssreta.py | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.py
> index 5e2d1b8..5c62c72 100644
> --- a/tests/TestSuite_pmdrssreta.py
> +++ b/tests/TestSuite_pmdrssreta.py
> @@ -62,42 +62,42 @@ class TestPmdrssreta(TestCase):
>           # send packet with different source and dest ip
>           if tran_type == "IPV4":
>               for i in range(16):
> -                packet = r'sendp([Ether(dst="%s")/IP(src="192.168.0.%d", dst="192.168.0.%d")], iface="%s")' % (
> +                packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IP(src="192.168.0.%d", dst="192.168.0.%d")], iface="%s")' % (
>                       mac, i + 1, i + 2, itf)
>                   self.tester.scapy_append(packet)
>                   self.tester.scapy_execute()
>                   time.sleep(.5)
>           elif tran_type == "IPV4&TCP":
>               for i in range(16):
> -                packet = r'sendp([Ether(dst="%s")/IP(src="192.168.0.%d", dst="192.168.0.%d")/TCP(sport=1024,dport=1024)], iface="%s")' % (
> +                packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IP(src="192.168.0.%d", dst="192.168.0.%d")/TCP(sport=1024,dport=1024)], iface="%s")' % (
>                       mac, i + 1, i + 2, itf)
>                   self.tester.scapy_append(packet)
>                   self.tester.scapy_execute()
>                   time.sleep(.5)
>           elif tran_type == "IPV4&UDP":
>               for i in range(16):
> -                packet = r'sendp([Ether(dst="%s")/IP(src="192.168.0.%d", dst="192.168.0.%d")/UDP(sport=1024,dport=1024)], iface="%s")' % (
> +                packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IP(src="192.168.0.%d", dst="192.168.0.%d")/UDP(sport=1024,dport=1024)], iface="%s")' % (
>                       mac, i + 1, i + 2, itf)
>                   self.tester.scapy_append(packet)
>                   self.tester.scapy_execute()
>                   time.sleep(.5)
>           elif tran_type == "IPV6":
>               for i in range(16):
> -                packet = r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d")], iface="%s")' % (
> +                packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d")], iface="%s")' % (
>                       mac, i + 1, i + 2, itf)
>                   self.tester.scapy_append(packet)
>                   self.tester.scapy_execute()
>                   time.sleep(.5)
>           elif tran_type == "IPV6&TCP":
>               for i in range(16):
> -                packet = r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d")/TCP(sport=1024,dport=1024)], iface="%s")' % (
> +                packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d")/TCP(sport=1024,dport=1024)], iface="%s")' % (
>                       mac, i + 1, i + 2, itf)
>                   self.tester.scapy_append(packet)
>                   self.tester.scapy_execute()
>                   time.sleep(.5)
>           elif tran_type == "IPV6&UDP":
>               for i in range(16):
> -                packet = r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d")/UDP(sport=1024,dport=1024)], iface="%s")' % (
> +                packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d")/UDP(sport=1024,dport=1024)], iface="%s")' % (
>                       mac, i + 1, i + 2, itf)
>                   self.tester.scapy_append(packet)
>                   self.tester.scapy_execute()
> @@ -148,7 +148,7 @@ class TestPmdrssreta(TestCase):
>           i = 0
>           for tmp_reta_line in reta_lines:
>               status = "false"
> -            if(self.nic == "niantic"):
> +            if(self.nic in ["niantic", "redrockcanyou"]):
>                   # compute the hash result of five tuple into the 7 LSBs value.
>                   hash_index = int(tmp_reta_line["RSS hash"], 16) % 128
>               else:
> @@ -212,7 +212,7 @@ class TestPmdrssreta(TestCase):
>                       "set nbcore %d" % (queue + 1), "testpmd> ")
>   
>                   # configure the reta with specific mappings.
> -                if(self.nic == "niantic"):
> +                if(self.nic in ["niantic", "redrockcanyou"]):
>                       for i in range(128):
>                           reta_entries.insert(i, random.randint(0, queue - 1))
>                           self.dut.send_expect(
> @@ -228,7 +228,7 @@ class TestPmdrssreta(TestCase):
>               self.dut.send_expect("quit", "# ", 30)
>   
>       def test_rss_key_size(self):
> -        nic_rss_key_size = {"fortville_eagle": 52, "fortville_spirit": 52, "fortville_spirit_single": 52, "niantic": 40, "e1000": 40}
> +        nic_rss_key_size = {"fortville_eagle": 52, "fortville_spirit": 52, "fortville_spirit_single": 52, "niantic": 40, "e1000": 40, "redrockcanyou":40}
>           self.verify(self.nic in nic_rss_key_size.keys(), "Not supporte rss key on %s" % self.nic)
>   
>           dutPorts = self.dut.get_ports(self.nic)

      reply	other threads:[~2015-10-22  7:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13  6:58 Michael Qiu
2015-10-22  7:45 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5628940C.3090003@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=michael.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).