test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH] fix queue start/stop case failed sometime print can't get received package info, used self.dut.get_session_output() replace self.dut.send_expect("\n", "testpmd>") get received package info
Date: Fri, 23 Oct 2015 15:33:40 +0800	[thread overview]
Message-ID: <5629E2D4.7080505@intel.com> (raw)
In-Reply-To: <1445583756-42712-1-git-send-email-huilongx.xu@intel.com>

Huilong,
It's better to separated the commit into two parts. This first part just 
one simple line describe the patch.
The second part is the detail description of the patch. Below is one 
sample for commit log.

tests: fix queue start/stop case can't capture log

Sometime print can't get received package info, used 
self.dut.get_session_output() replace self.dut.send_expect("\n", 
"testpmd>")  to get received package info.

Signed-off-by: XXXXXXX@XXXXXX

On 10/23/2015 03:02 PM, xu,huilong wrote:
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_queue_start_stop.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_queue_start_stop.py b/tests/TestSuite_queue_start_stop.py
> index 83504ab..f59333c 100644
> --- a/tests/TestSuite_queue_start_stop.py
> +++ b/tests/TestSuite_queue_start_stop.py
> @@ -164,7 +164,7 @@ class TestQueueStartStop(TestCase):
>               self.dut.send_expect("port 1 txq 0 stop", "testpmd>")
>               self.dut.send_expect("start", "testpmd>")
>               self.check_forwarding([0, 1], self.nic, received=False)
> -            out = self.dut.send_expect("\n", "testpmd>")
> +            out = self.dut.get_session_output()
>           except Exception, e:
>               raise IOError("queue start/stop forward failure: %s" % e)
>   

      reply	other threads:[~2015-10-23  7:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23  7:02 xu,huilong
2015-10-23  7:33 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5629E2D4.7080505@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).