From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 24BA8C458
 for <dts@dpdk.org>; Fri, 23 Oct 2015 09:31:22 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP; 23 Oct 2015 00:31:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,185,1444719600"; d="scan'208";a="670128268"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by orsmga003.jf.intel.com with ESMTP; 23 Oct 2015 00:31:21 -0700
Message-ID: <5629E2D4.7080505@intel.com>
Date: Fri, 23 Oct 2015 15:33:40 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
References: <1445583756-42712-1-git-send-email-huilongx.xu@intel.com>
In-Reply-To: <1445583756-42712-1-git-send-email-huilongx.xu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH] fix queue start/stop case failed sometime print
 can't get received package info,
 used self.dut.get_session_output() replace self.dut.send_expect("\n",
 "testpmd>") get received package info
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Oct 2015 07:31:23 -0000

Huilong,
It's better to separated the commit into two parts. This first part just 
one simple line describe the patch.
The second part is the detail description of the patch. Below is one 
sample for commit log.

tests: fix queue start/stop case can't capture log

Sometime print can't get received package info, used 
self.dut.get_session_output() replace self.dut.send_expect("\n", 
"testpmd>")  to get received package info.

Signed-off-by: XXXXXXX@XXXXXX

On 10/23/2015 03:02 PM, xu,huilong wrote:
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_queue_start_stop.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_queue_start_stop.py b/tests/TestSuite_queue_start_stop.py
> index 83504ab..f59333c 100644
> --- a/tests/TestSuite_queue_start_stop.py
> +++ b/tests/TestSuite_queue_start_stop.py
> @@ -164,7 +164,7 @@ class TestQueueStartStop(TestCase):
>               self.dut.send_expect("port 1 txq 0 stop", "testpmd>")
>               self.dut.send_expect("start", "testpmd>")
>               self.check_forwarding([0, 1], self.nic, received=False)
> -            out = self.dut.send_expect("\n", "testpmd>")
> +            out = self.dut.get_session_output()
>           except Exception, e:
>               raise IOError("queue start/stop forward failure: %s" % e)
>