test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Lijuan Tu <lijuanx.a.tu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [patch] physmem_dump : remove match "\n" send_expect will remove the end "\r\n", so it match failed if only one string
Date: Wed, 04 Nov 2015 12:49:42 +0800	[thread overview]
Message-ID: <56398E66.1050407@intel.com> (raw)
In-Reply-To: <1446611202-37081-1-git-send-email-lijuanx.a.tu@intel.com>

Applied. Please separate subject and commit log. Mail subject should be 
the description of this patch. The detail logs should be in  the mail 
content.

On 11/04/2015 12:26 PM, Lijuan Tu wrote:
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>   tests/TestSuite_unit_tests_dump.py |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py
> index 2052cb4..8b094b5 100644
> --- a/tests/TestSuite_unit_tests_dump.py
> +++ b/tests/TestSuite_unit_tests_dump.py
> @@ -129,7 +129,7 @@ class TestUnitTestsDump(TestCase):
>           match_regex = "Segment (\d)+:"
>           for element in elements[1:-1]:
>               match_regex += " %s:(.*?)," % element
> -        match_regex += " %s:(.*?)\n" % elements[-1]
> +        match_regex += " %s:(.*?)" % elements[-1]
>           m = re.compile(r"%s" % match_regex, re.DOTALL)
>           results = m.findall(out)
>           phy_info = []

      reply	other threads:[~2015-11-04  4:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04  4:26 Lijuan Tu
2015-11-04  4:49 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56398E66.1050407@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuanx.a.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).