From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8032C8E7B for ; Wed, 4 Nov 2015 08:05:31 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 03 Nov 2015 23:05:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,241,1444719600"; d="scan'208";a="811341666" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by orsmga001.jf.intel.com with ESMTP; 03 Nov 2015 23:05:16 -0800 Message-ID: <5639AE88.2010103@intel.com> Date: Wed, 04 Nov 2015 15:06:48 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Ding Heng , dts@dpdk.org References: <1446617147-7401-1-git-send-email-hengx.ding@intel.com> In-Reply-To: <1446617147-7401-1-git-send-email-hengx.ding@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH] TestSuite_tso: Fix only one port could receive packet issue in performance test. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 07:05:31 -0000 Hi Heng, Your patch look good for me. But i failed to applied it in for patch format issue. Could you check it and resend your patch? Thanks. On 11/04/2015 02:05 PM, Ding Heng wrote: > Configure different flows for different port. > > Signed-off-by: Ding Heng > > diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py > index 392157f..5bd8592 100644 > --- a/tests/TestSuite_tso.py > +++ b/tests/TestSuite_tso.py > @@ -306,14 +306,7 @@ class TestTSO(TestCase): > > # prepare traffic generator input > tgen_input = [] > - tgen_input.append((self.tester.get_local_port(self.dut_ports[0]), > - self.tester.get_local_port(self.dut_ports[1]), > - "test.pcap")) > - tgen_input.append((self.tester.get_local_port(self.dut_ports[1]), > - self.tester.get_local_port(self.dut_ports[0]), > - "test.pcap")) > > - mac = self.dut.get_mac_address(self.dut_ports[0]) > # run testpmd for each core config > for test_cycle in self.test_cycles: > core_config = test_cycle['cores'] > @@ -331,8 +324,7 @@ class TestTSO(TestCase): > dts.report(info, annex=True) > dts.report(command_line + "\n\n", frame=True, annex=True) > > - self.dut.send_expect(cmd, "testpmd> ", 120) > - self.dut.send_expect("set verbose 1", "testpmd> ", 120) > + self.dut.send_expect(command_line, "testpmd> ", 120) > self.dut.send_expect("csum set ip hw %d" % self.dut_ports[0], "testpmd> ", 120) > self.dut.send_expect("csum set udp hw %d" % self.dut_ports[0], "testpmd> ", 120) > self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd> ", 120) > @@ -354,7 +346,11 @@ class TestTSO(TestCase): > # create pcap file > self.logger.info("Running with frame size %d " % frame_size) > payload_size = frame_size - self.headers_size > - self.tester.scapy_append('wrpcap("test.pcap", [Ether(dst="%s",src="52:00:00:00:00:01")/IP(src="192.168.1.1",dst="192.168.1.2")/TCP(sport=1021,dport=1021)/("X"*%d)])' % (mac, payload_size)) > + for _port in range(2): > + mac = self.dut.get_mac_address(self.dut_ports[_port]) > + self.tester.scapy_append('wrpcap("dst%d.pcap", [Ether(dst="%s",src="52:00:00:00:00:01")/IP(src="192.168.1.1",dst="192.168.1.2")/TCP(sport=1021,dport=1021)/("X"*%d)])' % (_port, mac, payload_size)) > + tgen_input.append((self.tester.get_local_port(self.dut_ports[_port]), > + self.tester.get_local_port(self.dut_ports[1-_port]), "dst%d.pcap") % _port) > self.tester.scapy_execute() > > # run traffic generator