From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4F0128E6C for ; Wed, 4 Nov 2015 08:08:52 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 03 Nov 2015 23:08:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,241,1444719600"; d="scan'208";a="842701857" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2015 23:08:50 -0800 Message-ID: <5639AF5F.50208@intel.com> Date: Wed, 04 Nov 2015 15:10:23 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Qiu, Michael" , "dts@dpdk.org" References: <1444792509-19136-1-git-send-email-michael.qiu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E10F2AE87@SHSMSX103.ccr.corp.intel.com> <533710CFB86FA344BFBF2D6802E6028621B6571C@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E6028621B6571C@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH] jumboframes: Fix bug for fm10k NIC X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 07:08:52 -0000 Hi Michael, That's fine. Applied this patch, thanks. On 11/04/2015 01:45 PM, Qiu, Michael wrote: > Hi, Marvin > > Just as I said in other thread, I will make a patch to update the list. > > And what about this patch? > > Thanks, > Michael > > On 2015/10/14 18:19, Liu, Yong wrote: >> Hi Michael, >> Same comment, we have excel file tracking those features what we do not support. >> For the RRC Testpoint, I think we need implement one structure for this. We cannot reply on manual commands to run DTS. >> >>> -----Original Message----- >>> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Michael Qiu >>> Sent: Wednesday, October 14, 2015 4:15 AM >>> To: dts@dpdk.org >>> Subject: [dts] [PATCH] jumboframes: Fix bug for fm10k NIC >>> >>> For Ruby Rapid, in Testpoint should run "set port config 1,5 >>> max_frame_size 9000" >>> and "set port config 1,5,20,22 rx_cut_through off" >>> >>> Singed-off-by: Michael Qiu >>> --- >>> tests/TestSuite_jumboframes.py | 12 ++++++++---- >>> 1 file changed, 8 insertions(+), 4 deletions(-) >>> >>> diff --git a/tests/TestSuite_jumboframes.py >>> b/tests/TestSuite_jumboframes.py >>> index c5c70b9..e9a6abf 100644 >>> --- a/tests/TestSuite_jumboframes.py >>> +++ b/tests/TestSuite_jumboframes.py >>> @@ -93,7 +93,9 @@ class TestJumboframes(TestCase): >>> p1rx_err -= gp1rx_err >>> >>> if received: >>> - self.verify(p0tx_pkts == p1rx_pkts and p0tx_bytes == pktsize >>> and p1rx_bytes == pktsize, >>> + #some nic like RRC always strip CRC, so it should be pktsize >>> - 4 >>> + size_equal = p0tx_bytes == p1rx_bytes and (p1rx_bytes == >>> pktsize or p1rx_bytes == pktsize - 4) >>> + self.verify(p0tx_pkts == p1rx_pkts and size_equal, >>> "packet pass assert error") >>> else: >>> #self.verify(p0tx_pkts == p1rx_pkts and (p1rx_err == 1 or >>> p1rx_pkts == 0), >>> @@ -152,10 +154,12 @@ class TestJumboframes(TestCase): >>> This case aims to test transmitting jumbo frame packet on testpmd >>> without >>> jumbo frame support. >>> """ >>> - self.pmdout.start_testpmd("Default", "--max-pkt-len=%d" % >>> (ETHER_STANDARD_MTU)) >>> + # RRC has no ability to set the max pkt len to hardware >>> if self.nic == "redrockcanyou": >>> - self.dut.send_expect("set promisc all off", "testpmd> ") >>> - self.dut.send_expect("set fwd mac", "testpmd> ") >>> + print dts.RED("fm10k not support this case\n") >>> + return >>> + self.pmdout.start_testpmd("Default", "--max-pkt-len=%d" % >>> (ETHER_STANDARD_MTU)) >>> + self.dut.send_expect("set fwd mac", "testpmd> ") >>> self.dut.send_expect("start", "testpmd> ") >>> >>> self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False) >>> -- >>> 1.9.3 >