From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 09A82532D for ; Tue, 10 Nov 2015 09:11:20 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 10 Nov 2015 00:11:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,269,1444719600"; d="scan'208";a="832640848" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by fmsmga001.fm.intel.com with ESMTP; 10 Nov 2015 00:11:19 -0800 Message-ID: <5641A6EB.9000107@intel.com> Date: Tue, 10 Nov 2015 16:12:27 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Raslan Darawsheh , "Xu, HuilongX" , "dts@dpdk.org" References: <1445926076-31279-1-git-send-email-rasland@mellanox.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "rdarawsheh@asaltech.com" Subject: Re: [dts] [PATCH 1/6] framework: crb :add some parameters and check_Mellanox_pci function to identify mellanox device X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 08:11:21 -0000 Hi Darawsheh, As you known, dpdk2.2 has been in validation cycle. We're now busying in the validation task. Your patch look has different concept of NIC handling. In DTS by now, CRB do not need to known which NIC is on board. Please wait one more week. After the validation task, we will figure out how to handle the patch. Best regards, Marvin On 11/10/2015 02:32 PM, Raslan Darawsheh wrote: > Hi Xu, HuilongX , > > When do you think you will apply the patches? > > Kindest regards > Raslan Darawsheh > > > -----Original Message----- > From: Xu, HuilongX [mailto:huilongx.xu@intel.com] > Sent: Thursday, October 29, 2015 12:10 PM > To: Raslan Darawsheh; dts@dpdk.org > Cc: rdarawsheh@asaltech.com > Subject: RE: [dts] [PATCH 1/6] framework: crb :add some parameters and check_Mellanox_pci function to identify mellanox device > > Hi Darawsheh, > I am very sorry, I am too careless. > Your changed in function " pci_devices_information_uncached_linux", so it's no problem Thanks a lot >> -----Original Message----- >> From: Raslan Darawsheh [mailto:rasland@mellanox.com] >> Sent: Thursday, October 29, 2015 5:58 PM >> To: Xu, HuilongX; dts@dpdk.org >> Cc: rdarawsheh@asaltech.com >> Subject: RE: [dts] [PATCH 1/6] framework: crb :add some parameters and >> check_Mellanox_pci function to identify mellanox device >> >> Hi Xu, HuilongX, >> >> I think you need to double check the patch, since in this patch it >> doesn't change anything to this function. >> >> Kindest regards >> Raslan Darawsheh >> >> -----Original Message----- >> From: Xu, HuilongX [mailto:huilongx.xu@intel.com] >> Sent: Thursday, October 29, 2015 10:48 AM >> To: Raslan Darawsheh ; dts@dpdk.org >> Cc: rdarawsheh@asaltech.com >> Subject: RE: [dts] [PATCH 1/6] framework: crb :add some parameters and >> check_Mellanox_pci function to identify mellanox device >> >> Hi Darawsheh, >> Your changed can't work on FreeBSD OS, but function "get_session_output" >> in crb.py need work on FreeBSD os. >> Thanks a lot >> >>> -----Original Message----- >>> From: Raslan Darawsheh [mailto:rasland@mellanox.com] >>> Sent: Thursday, October 29, 2015 4:05 PM >>> To: Xu, HuilongX; dts@dpdk.org >>> Cc: rdarawsheh@asaltech.com >>> Subject: RE: [dts] [PATCH 1/6] framework: crb :add some parameters >>> and check_Mellanox_pci function to identify mellanox device >>> >>> Hi Xu, HuilongX , >>> >>> From what I changed it seems that it's only executed over the linux OS. >>> And there are an already "lspci" command executed inside the function. >>> Can you explain more ? >>> Kindest regards >>> Raslan Darawsheh >>> >>> -----Original Message----- >>> From: Xu, HuilongX [mailto:huilongx.xu@intel.com] >>> Sent: Thursday, October 29, 2015 4:01 AM >>> To: Raslan Darawsheh ; dts@dpdk.org >>> Cc: rdarawsheh@asaltech.com >>> Subject: RE: [dts] [PATCH 1/6] framework: crb :add some parameters >>> and check_Mellanox_pci function to identify mellanox device >>> >>> >>> Hi darawsheh, >>> Pls see my comments as below., thanks a lot >>>> -----Original Message----- >>>> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Raslan >>>> Darawsheh >>>> Sent: Tuesday, October 27, 2015 2:08 PM >>>> To: dts@dpdk.org >>>> Cc: rdarawsheh@asaltech.com >>>> Subject: [dts] [PATCH 1/6] framework: crb :add some parameters and >>>> check_Mellanox_pci function to identify mellanox device >>>> >>>> From: Raslsn Darawsheh >>>> >>>> Signed-off-by: Raslsn Darawsheh >>>> --- >>>> framework/crb.py | 23 ++++++++++++++++++++++- >>>> 1 file changed, 22 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/framework/crb.py b/framework/crb.py index >>>> fcbd7d9..0acec3b 100644 >>>> --- a/framework/crb.py >>>> +++ b/framework/crb.py >>>> @@ -33,7 +33,7 @@ import time >>>> import dts >>>> import re >>>> import os >>>> -from settings import TIMEOUT, IXIA >>>> +from settings import TIMEOUT, IXIA, NICS >>>> >>>> """ >>>> CRB (customer reference board) basic functions and handlers @@ >>>> -54,6 >>>> +54,9 @@ class Crb(object): >>>> self.skip_setup = False >>>> self.serializer = serializer >>>> self.ports_info = None >>>> + self.isMellanox = False >>>> + self.mellanoxPortCount = 0 >>>> + self.mellanoxCardType = None >>>> >>>> def send_expect(self, cmds, expected, timeout=TIMEOUT, >>>> alt_session=False, verify=False): >>>> @@ -79,6 +82,19 @@ class Crb(object): >>>> >>>> return self.session.send_command(cmds, timeout) >>>> >>>> + def check_Mellanox_pci(self,pci_bus,pci_id): >>>> + """ >>>> + check if the PCI is Mellanox device or not >>>> + its used to set a flag to handle Mellanox ports differently >>>> + """ >>>> + out = self.send_expect("lspci -nn | grep -i " + pci_bus, >>>> + "# >> ") >>>> + if "Mell" in out: >>>> + self.isMellanox =True >>>> + if NICS['ConnectX_4'] in out: >>>> + self.mellanoxCardType = "cx4" >>>> + else: >>>> + self.mellanoxCardType = "cx3" >>>> + >>>> def get_session_output(self, timeout=TIMEOUT): >>>> """ >>>> Get session output message before timeout @@ -196,6 >>>> +212,11 @@ class Crb(object): >>>> rexp = r"([\da-f]{2}:[\da-f]{2}.\d{1}) .*Eth.*?ernet >>>> .*?([\da- f]{4}:[\da-f]{4})" >>>> pattern = re.compile(rexp) >>>> match = pattern.findall(out) >>> Could you not changed this function? because it not about dts >>> feature It only a ssh session function, when you exec "lspci" >>> command, freebsd os not support. >>> So some case will failed on freebesd. >>>> + out = self.send_expect( >>>> + "lspci -nn ", "# ", alt_session=True) >>>> + rexp = r"([\da-f]{2}:[\da-f]{2}.\d{1}) Network .*?([\da- >>>> f]{4}:[\da-f]{4})" >>>> + pattern = re.compile(rexp) >>>> + match += pattern.findall(out) >>>> self.pci_devices_info = [] >>>> for i in range(len(match)): >>>> self.pci_devices_info.append((match[i][0], >>>> match[i][1])) >>>> -- >>>> 1.8.3.1