From: "Liu, Yong" <yong.liu@intel.com>
To: yongjie <yongjiex.gu@intel.com>, dts@dpdk.org
Cc: root <root@linux-9riq.site>
Subject: Re: [dts] [PATCH] fix shutdown api 1G nics bug
Date: Wed, 11 Nov 2015 16:56:54 +0800 [thread overview]
Message-ID: <564302D6.1060909@intel.com> (raw)
In-Reply-To: <1447231140-8639-1-git-send-email-yongjiex.gu@intel.com>
Hi Yongjie,
Thanks, and one comment below.
On 11/11/2015 04:39 PM, yongjie wrote:
> From: root <root@linux-9riq.site>
>
> Signed-off-by: root <root@linux-9riq.site>
> ---
> tests/TestSuite_shutdown_api.py | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
> index d672d50..2202ae1 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -147,8 +147,7 @@ class TestShutdownApi(TestCase):
> rx_bytes_exp -= 4
> tx_bytes_exp -= 4
> elif self.nic in ["fortville_eagle", "fortville_spirit",
> - "fortville_spirit_single", "bartonhills",
> - "powerville", "springville", "hartwell"]:
> + "fortville_spirit_single", "bartonhills"]:
> # some NIC will always strip tx crc
> tx_bytes_exp -= 4
> if vlan is True:
> @@ -156,7 +155,7 @@ class TestShutdownApi(TestCase):
> tx_bytes_exp -= 4
> else:
> # some NIC will always include tx crc
> - if crcStrip is True:
> + if crcStrip is True and self.nic not in ["springville", "powerville"]:
This condition is for default nic like niantic. If "powerville" and
"sprintville" not act like this, please add whole new condition.
> rx_bytes_exp -= 4
> if vlan is True:
> # vlan strip default is on
> @@ -354,7 +353,7 @@ class TestShutdownApi(TestCase):
> self.dut.send_expect("port start all", "testpmd> ", 100)
> self.dut.send_expect("start", "testpmd> ")
>
> - if self.nic in ['niantic']:
> + if self.nic in ['niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville']:
> # nantic vlan length will not be calculated
> vlan_jumbo_size = jumbo_size + 4
> else:
prev parent reply other threads:[~2015-11-11 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 8:39 yongjie
2015-11-11 8:56 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564302D6.1060909@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=root@linux-9riq.site \
--cc=yongjiex.gu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).