* [dts] [PATCH] fix shutdown api 1G nics bug
@ 2015-11-11 8:39 yongjie
2015-11-11 8:56 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: yongjie @ 2015-11-11 8:39 UTC (permalink / raw)
To: dts; +Cc: root
From: root <root@linux-9riq.site>
Signed-off-by: root <root@linux-9riq.site>
---
tests/TestSuite_shutdown_api.py | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index d672d50..2202ae1 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -147,8 +147,7 @@ class TestShutdownApi(TestCase):
rx_bytes_exp -= 4
tx_bytes_exp -= 4
elif self.nic in ["fortville_eagle", "fortville_spirit",
- "fortville_spirit_single", "bartonhills",
- "powerville", "springville", "hartwell"]:
+ "fortville_spirit_single", "bartonhills"]:
# some NIC will always strip tx crc
tx_bytes_exp -= 4
if vlan is True:
@@ -156,7 +155,7 @@ class TestShutdownApi(TestCase):
tx_bytes_exp -= 4
else:
# some NIC will always include tx crc
- if crcStrip is True:
+ if crcStrip is True and self.nic not in ["springville", "powerville"]:
rx_bytes_exp -= 4
if vlan is True:
# vlan strip default is on
@@ -354,7 +353,7 @@ class TestShutdownApi(TestCase):
self.dut.send_expect("port start all", "testpmd> ", 100)
self.dut.send_expect("start", "testpmd> ")
- if self.nic in ['niantic']:
+ if self.nic in ['niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville']:
# nantic vlan length will not be calculated
vlan_jumbo_size = jumbo_size + 4
else:
--
1.8.5.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH] fix shutdown api 1G nics bug
2015-11-11 8:39 [dts] [PATCH] fix shutdown api 1G nics bug yongjie
@ 2015-11-11 8:56 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2015-11-11 8:56 UTC (permalink / raw)
To: yongjie, dts; +Cc: root
Hi Yongjie,
Thanks, and one comment below.
On 11/11/2015 04:39 PM, yongjie wrote:
> From: root <root@linux-9riq.site>
>
> Signed-off-by: root <root@linux-9riq.site>
> ---
> tests/TestSuite_shutdown_api.py | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
> index d672d50..2202ae1 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -147,8 +147,7 @@ class TestShutdownApi(TestCase):
> rx_bytes_exp -= 4
> tx_bytes_exp -= 4
> elif self.nic in ["fortville_eagle", "fortville_spirit",
> - "fortville_spirit_single", "bartonhills",
> - "powerville", "springville", "hartwell"]:
> + "fortville_spirit_single", "bartonhills"]:
> # some NIC will always strip tx crc
> tx_bytes_exp -= 4
> if vlan is True:
> @@ -156,7 +155,7 @@ class TestShutdownApi(TestCase):
> tx_bytes_exp -= 4
> else:
> # some NIC will always include tx crc
> - if crcStrip is True:
> + if crcStrip is True and self.nic not in ["springville", "powerville"]:
This condition is for default nic like niantic. If "powerville" and
"sprintville" not act like this, please add whole new condition.
> rx_bytes_exp -= 4
> if vlan is True:
> # vlan strip default is on
> @@ -354,7 +353,7 @@ class TestShutdownApi(TestCase):
> self.dut.send_expect("port start all", "testpmd> ", 100)
> self.dut.send_expect("start", "testpmd> ")
>
> - if self.nic in ['niantic']:
> + if self.nic in ['niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville']:
> # nantic vlan length will not be calculated
> vlan_jumbo_size = jumbo_size + 4
> else:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-11 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-11 8:39 [dts] [PATCH] fix shutdown api 1G nics bug yongjie
2015-11-11 8:56 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).