From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id C80E25A97
 for <dts@dpdk.org>; Wed, 11 Nov 2015 09:55:30 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga101.jf.intel.com with ESMTP; 11 Nov 2015 00:55:29 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,274,1444719600"; d="scan'208";a="833995168"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by fmsmga001.fm.intel.com with ESMTP; 11 Nov 2015 00:55:21 -0800
Message-ID: <564302D6.1060909@intel.com>
Date: Wed, 11 Nov 2015 16:56:54 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: yongjie <yongjiex.gu@intel.com>, dts@dpdk.org
References: <1447231140-8639-1-git-send-email-yongjiex.gu@intel.com>
In-Reply-To: <1447231140-8639-1-git-send-email-yongjiex.gu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: root <root@linux-9riq.site>
Subject: Re: [dts] [PATCH] fix shutdown api 1G nics bug
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Nov 2015 08:55:31 -0000

Hi Yongjie,
Thanks, and one comment below.

On 11/11/2015 04:39 PM, yongjie wrote:
> From: root <root@linux-9riq.site>
>
> Signed-off-by: root <root@linux-9riq.site>
> ---
>   tests/TestSuite_shutdown_api.py | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
> index d672d50..2202ae1 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -147,8 +147,7 @@ class TestShutdownApi(TestCase):
>                   rx_bytes_exp -= 4
>                   tx_bytes_exp -= 4
>           elif self.nic in ["fortville_eagle", "fortville_spirit",
> -                        "fortville_spirit_single", "bartonhills",
> -                        "powerville", "springville", "hartwell"]:
> +                        "fortville_spirit_single", "bartonhills"]:
>               # some NIC will always strip tx crc
>               tx_bytes_exp -= 4
>               if vlan is True:
> @@ -156,7 +155,7 @@ class TestShutdownApi(TestCase):
>                   tx_bytes_exp -= 4
>           else:
>               # some NIC will always include tx crc
> -            if crcStrip is True:
> +            if crcStrip is True and self.nic not in ["springville", "powerville"]:
This condition is for default nic like niantic. If "powerville" and 
"sprintville" not act like this, please add whole new condition.

>                   rx_bytes_exp -= 4
>               if vlan is True:
>                   # vlan strip default is on
> @@ -354,7 +353,7 @@ class TestShutdownApi(TestCase):
>           self.dut.send_expect("port start all", "testpmd> ", 100)
>           self.dut.send_expect("start", "testpmd> ")
>   
> -        if self.nic in ['niantic']:
> +        if self.nic in ['niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville']:
>               # nantic vlan length will not be calculated
>               vlan_jumbo_size = jumbo_size + 4
>           else: