test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: yongjie <yongjiex.gu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH] fix shutdown api bug on 1G nics
Date: Wed, 11 Nov 2015 22:46:58 +0800	[thread overview]
Message-ID: <564354E2.7080009@intel.com> (raw)
In-Reply-To: <1447232672-9002-1-git-send-email-yongjiex.gu@intel.com>

Applied. Thanks.

On 11/11/2015 05:04 PM, yongjie wrote:
> From: Gu yongjie <yongjiex.gu@intel.com>
>
>
> Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
> ---
>   tests/TestSuite_shutdown_api.py |    9 ++++++---
>   1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
> index d672d50..3800669 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -147,13 +147,16 @@ class TestShutdownApi(TestCase):
>                   rx_bytes_exp -= 4
>                   tx_bytes_exp -= 4
>           elif self.nic in ["fortville_eagle", "fortville_spirit",
> -                        "fortville_spirit_single", "bartonhills",
> -                        "powerville", "springville", "hartwell"]:
> +                        "fortville_spirit_single", "bartonhills"]:
>               # some NIC will always strip tx crc
>               tx_bytes_exp -= 4
>               if vlan is True:
>                   # vlan strip default is on
>                   tx_bytes_exp -= 4
> +        elif self.nic in ["springville", "powerville"]:
> +            if vlan is True:
> +                # vlan strip default is on
> +                tx_bytes_exp -= 4
>           else:
>               # some NIC will always include tx crc
>               if crcStrip is True:
> @@ -354,7 +357,7 @@ class TestShutdownApi(TestCase):
>           self.dut.send_expect("port start all", "testpmd> ", 100)
>           self.dut.send_expect("start", "testpmd> ")
>   
> -        if self.nic in ['niantic']:
> +        if self.nic in ['niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville']:
>               # nantic vlan length will not be calculated
>               vlan_jumbo_size = jumbo_size + 4
>           else:

  reply	other threads:[~2015-11-11 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11  9:04 yongjie
2015-11-11 14:46 ` Liu, Yong [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-11-11  8:45 yongjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564354E2.7080009@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yongjiex.gu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).