test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Jingguo Fu <jingguox.fu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [DTS][PATCH] fix jumbo frame crc issue for fortville nics
Date: Fri, 13 Nov 2015 17:14:28 +0800	[thread overview]
Message-ID: <5645A9F4.7050007@intel.com> (raw)
In-Reply-To: <1447400109-19286-1-git-send-email-jingguox.fu@intel.com>

Applied. Thanks.

On 11/13/2015 03:35 PM, Jingguo Fu wrote:
> Changes to be committed:
> 	modified:   tests/TestSuite_jumboframes.py
Take care, this should not be included in commit log.

> Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
> ---
>   tests/TestSuite_jumboframes.py | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_jumboframes.py b/tests/TestSuite_jumboframes.py
> index d9261e6..a295624 100644
> --- a/tests/TestSuite_jumboframes.py
> +++ b/tests/TestSuite_jumboframes.py
> @@ -93,10 +93,12 @@ class TestJumboframes(TestCase):
>           p1rx_err -= gp1rx_err
>   
>           if received:
> -            #some nic like RRC always strip CRC, so it should be pktsize - 4
> -            size_equal = p0tx_bytes == p1rx_bytes and (p1rx_bytes == pktsize or  p1rx_bytes == pktsize - 4)
> -            self.verify(p0tx_pkts == p1rx_pkts and size_equal,
> -                        "packet pass assert error")
> +            if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single"]:
> +                self.verify((p0tx_pkts == p1rx_pkts) and ((p0tx_bytes + 4) == pktsize) and (p1rx_bytes == pktsize),
> +                            "packet pass assert error")
> +            else:
> +                self.verify((p0tx_pkts == p1rx_pkts) and (p0tx_bytes == pktsize) and (p1rx_bytes == pktsize),
> +                            "packet pass assert error")
>           else:
>               #self.verify(p0tx_pkts == p1rx_pkts and (p1rx_err == 1 or p1rx_pkts == 0),
>               self.verify(p1rx_err == 1 or p0tx_pkts == 0, "packet drop assert error")

      reply	other threads:[~2015-11-13  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13  7:35 Jingguo Fu
2015-11-13  9:14 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5645A9F4.7050007@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=jingguox.fu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).