From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 1EB1793A4
 for <dts@dpdk.org>; Fri, 13 Nov 2015 10:13:05 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 13 Nov 2015 01:13:03 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,286,1444719600"; d="scan'208";a="850226158"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by fmsmga002.fm.intel.com with ESMTP; 13 Nov 2015 01:13:03 -0800
Message-ID: <5645A9F4.7050007@intel.com>
Date: Fri, 13 Nov 2015 17:14:28 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Jingguo Fu <jingguox.fu@intel.com>, dts@dpdk.org
References: <1447400109-19286-1-git-send-email-jingguox.fu@intel.com>
In-Reply-To: <1447400109-19286-1-git-send-email-jingguox.fu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [DTS][PATCH] fix jumbo frame crc issue for fortville nics
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Nov 2015 09:13:06 -0000

Applied. Thanks.

On 11/13/2015 03:35 PM, Jingguo Fu wrote:
> Changes to be committed:
> 	modified:   tests/TestSuite_jumboframes.py
Take care, this should not be included in commit log.

> Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
> ---
>   tests/TestSuite_jumboframes.py | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_jumboframes.py b/tests/TestSuite_jumboframes.py
> index d9261e6..a295624 100644
> --- a/tests/TestSuite_jumboframes.py
> +++ b/tests/TestSuite_jumboframes.py
> @@ -93,10 +93,12 @@ class TestJumboframes(TestCase):
>           p1rx_err -= gp1rx_err
>   
>           if received:
> -            #some nic like RRC always strip CRC, so it should be pktsize - 4
> -            size_equal = p0tx_bytes == p1rx_bytes and (p1rx_bytes == pktsize or  p1rx_bytes == pktsize - 4)
> -            self.verify(p0tx_pkts == p1rx_pkts and size_equal,
> -                        "packet pass assert error")
> +            if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single"]:
> +                self.verify((p0tx_pkts == p1rx_pkts) and ((p0tx_bytes + 4) == pktsize) and (p1rx_bytes == pktsize),
> +                            "packet pass assert error")
> +            else:
> +                self.verify((p0tx_pkts == p1rx_pkts) and (p0tx_bytes == pktsize) and (p1rx_bytes == pktsize),
> +                            "packet pass assert error")
>           else:
>               #self.verify(p0tx_pkts == p1rx_pkts and (p1rx_err == 1 or p1rx_pkts == 0),
>               self.verify(p1rx_err == 1 or p0tx_pkts == 0, "packet drop assert error")