test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: yongjie <yongjiex.gu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH] fix scatter format and time bug
Date: Mon, 16 Nov 2015 08:40:16 +0800	[thread overview]
Message-ID: <564925F0.1040403@intel.com> (raw)
In-Reply-To: <1447492939-12553-1-git-send-email-yongjiex.gu@intel.com>

Applied. Thanks.

On 11/14/2015 05:22 PM, yongjie wrote:
> From: Gu yongjie <yongjiex.gu@intel.com>
>
>
> Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
> ---
>   tests/TestSuite_scatter.py |    7 ++++---
>   1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
> index 001f0b4..3a761c4 100644
> --- a/tests/TestSuite_scatter.py
> +++ b/tests/TestSuite_scatter.py
> @@ -82,16 +82,17 @@ class TestScatter(TestCase):
>           self.tester.send_expect("ifconfig %s mtu 9000" % sintf, "#")
>           self.tester.send_expect("ifconfig %s mtu 9000" % rintf, "#")
>   
> -		self.start_tcpdump(rintf)
> +        self.start_tcpdump(rintf)
>   
>           pktlen = pktsize - 18
>           padding = pktlen - 20
>   
>           self.tester.scapy_append(
>               'sendp([Ether(src="%s",dst="%s")/IP(len=%s)/Raw(load="\x50"*%s)], iface="%s")' % (smac, dmac,pktlen, padding, sintf))
> +        time.sleep(3)
>           self.tester.scapy_execute()
>           time.sleep(5) #wait for scapy capture subprocess exit
> -		res = self.get_tcpdump_packet()
> +        res = self.get_tcpdump_packet()
>           self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
>           self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
>           return res
> @@ -122,7 +123,7 @@ class TestScatter(TestCase):
>           for offset in [-1, 0, 1, 4, 5]:
>               ret = self.scatter_pktgen_send_packet(
>                   dutPorts[0], dutPorts[1], self.mbsize + offset)
> -			self.verify("5050 5050 5050 5050 5050 5050 5050" in ret, "packet receive error")
> +            self.verify("5050 5050 5050 5050 5050 5050 5050" in ret, "packet receive error")
>   
>           self.dut.send_expect("stop", "testpmd> ")
>           self.dut.send_expect("quit", "# ", 30)

      reply	other threads:[~2015-11-16  0:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14  9:22 yongjie
2015-11-16  0:40 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564925F0.1040403@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yongjiex.gu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).