test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] fix scatter format and time bug
@ 2015-11-14  9:22 yongjie
  2015-11-16  0:40 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: yongjie @ 2015-11-14  9:22 UTC (permalink / raw)
  To: dts; +Cc: Gu yongjie

From: Gu yongjie <yongjiex.gu@intel.com>


Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
---
 tests/TestSuite_scatter.py |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
index 001f0b4..3a761c4 100644
--- a/tests/TestSuite_scatter.py
+++ b/tests/TestSuite_scatter.py
@@ -82,16 +82,17 @@ class TestScatter(TestCase):
         self.tester.send_expect("ifconfig %s mtu 9000" % sintf, "#")
         self.tester.send_expect("ifconfig %s mtu 9000" % rintf, "#")
 
-		self.start_tcpdump(rintf)
+        self.start_tcpdump(rintf)
 
         pktlen = pktsize - 18
         padding = pktlen - 20
 
         self.tester.scapy_append(
             'sendp([Ether(src="%s",dst="%s")/IP(len=%s)/Raw(load="\x50"*%s)], iface="%s")' % (smac, dmac,pktlen, padding, sintf))
+        time.sleep(3)
         self.tester.scapy_execute()
         time.sleep(5) #wait for scapy capture subprocess exit
-		res = self.get_tcpdump_packet()
+        res = self.get_tcpdump_packet()
         self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
         self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
         return res
@@ -122,7 +123,7 @@ class TestScatter(TestCase):
         for offset in [-1, 0, 1, 4, 5]:
             ret = self.scatter_pktgen_send_packet(
                 dutPorts[0], dutPorts[1], self.mbsize + offset)
-			self.verify("5050 5050 5050 5050 5050 5050 5050" in ret, "packet receive error")
+            self.verify("5050 5050 5050 5050 5050 5050 5050" in ret, "packet receive error")
 
         self.dut.send_expect("stop", "testpmd> ")
         self.dut.send_expect("quit", "# ", 30)
-- 
1.7.4.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] fix scatter format and time bug
  2015-11-14  9:22 [dts] [PATCH] fix scatter format and time bug yongjie
@ 2015-11-16  0:40 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2015-11-16  0:40 UTC (permalink / raw)
  To: yongjie, dts

Applied. Thanks.

On 11/14/2015 05:22 PM, yongjie wrote:
> From: Gu yongjie <yongjiex.gu@intel.com>
>
>
> Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
> ---
>   tests/TestSuite_scatter.py |    7 ++++---
>   1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
> index 001f0b4..3a761c4 100644
> --- a/tests/TestSuite_scatter.py
> +++ b/tests/TestSuite_scatter.py
> @@ -82,16 +82,17 @@ class TestScatter(TestCase):
>           self.tester.send_expect("ifconfig %s mtu 9000" % sintf, "#")
>           self.tester.send_expect("ifconfig %s mtu 9000" % rintf, "#")
>   
> -		self.start_tcpdump(rintf)
> +        self.start_tcpdump(rintf)
>   
>           pktlen = pktsize - 18
>           padding = pktlen - 20
>   
>           self.tester.scapy_append(
>               'sendp([Ether(src="%s",dst="%s")/IP(len=%s)/Raw(load="\x50"*%s)], iface="%s")' % (smac, dmac,pktlen, padding, sintf))
> +        time.sleep(3)
>           self.tester.scapy_execute()
>           time.sleep(5) #wait for scapy capture subprocess exit
> -		res = self.get_tcpdump_packet()
> +        res = self.get_tcpdump_packet()
>           self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
>           self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
>           return res
> @@ -122,7 +123,7 @@ class TestScatter(TestCase):
>           for offset in [-1, 0, 1, 4, 5]:
>               ret = self.scatter_pktgen_send_packet(
>                   dutPorts[0], dutPorts[1], self.mbsize + offset)
> -			self.verify("5050 5050 5050 5050 5050 5050 5050" in ret, "packet receive error")
> +            self.verify("5050 5050 5050 5050 5050 5050 5050" in ret, "packet receive error")
>   
>           self.dut.send_expect("stop", "testpmd> ")
>           self.dut.send_expect("quit", "# ", 30)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-16  0:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-14  9:22 [dts] [PATCH] fix scatter format and time bug yongjie
2015-11-16  0:40 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).