From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 6E9DD9598
 for <dts@dpdk.org>; Mon, 16 Nov 2015 01:39:03 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga101.jf.intel.com with ESMTP; 15 Nov 2015 16:39:02 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,299,1444719600"; d="scan'208";a="851440440"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by orsmga002.jf.intel.com with ESMTP; 15 Nov 2015 16:39:01 -0800
Message-ID: <564925F0.1040403@intel.com>
Date: Mon, 16 Nov 2015 08:40:16 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: yongjie <yongjiex.gu@intel.com>, dts@dpdk.org
References: <1447492939-12553-1-git-send-email-yongjiex.gu@intel.com>
In-Reply-To: <1447492939-12553-1-git-send-email-yongjiex.gu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH] fix scatter format and time bug
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Nov 2015 00:39:04 -0000

Applied. Thanks.

On 11/14/2015 05:22 PM, yongjie wrote:
> From: Gu yongjie <yongjiex.gu@intel.com>
>
>
> Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
> ---
>   tests/TestSuite_scatter.py |    7 ++++---
>   1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
> index 001f0b4..3a761c4 100644
> --- a/tests/TestSuite_scatter.py
> +++ b/tests/TestSuite_scatter.py
> @@ -82,16 +82,17 @@ class TestScatter(TestCase):
>           self.tester.send_expect("ifconfig %s mtu 9000" % sintf, "#")
>           self.tester.send_expect("ifconfig %s mtu 9000" % rintf, "#")
>   
> -		self.start_tcpdump(rintf)
> +        self.start_tcpdump(rintf)
>   
>           pktlen = pktsize - 18
>           padding = pktlen - 20
>   
>           self.tester.scapy_append(
>               'sendp([Ether(src="%s",dst="%s")/IP(len=%s)/Raw(load="\x50"*%s)], iface="%s")' % (smac, dmac,pktlen, padding, sintf))
> +        time.sleep(3)
>           self.tester.scapy_execute()
>           time.sleep(5) #wait for scapy capture subprocess exit
> -		res = self.get_tcpdump_packet()
> +        res = self.get_tcpdump_packet()
>           self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
>           self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
>           return res
> @@ -122,7 +123,7 @@ class TestScatter(TestCase):
>           for offset in [-1, 0, 1, 4, 5]:
>               ret = self.scatter_pktgen_send_packet(
>                   dutPorts[0], dutPorts[1], self.mbsize + offset)
> -			self.verify("5050 5050 5050 5050 5050 5050 5050" in ret, "packet receive error")
> +            self.verify("5050 5050 5050 5050 5050 5050 5050" in ret, "packet receive error")
>   
>           self.dut.send_expect("stop", "testpmd> ")
>           self.dut.send_expect("quit", "# ", 30)