test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Jingguo Fu <jingguox.fu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [DTS][PATCH] fix dut port config bug: numa is int, does not have lower attr Changes to be committed: modified: framework/dut.py
Date: Mon, 23 Nov 2015 14:44:58 +0800	[thread overview]
Message-ID: <5652B5EA.3020900@intel.com> (raw)
In-Reply-To: <56457C63.6060600@intel.com>

Applied. Thanks.

On 11/13/2015 02:00 PM, Liu, Yong wrote:
> Hi Jingguo,
> Please add warning when configuration not match real. And please 
> separate comments from email subject.
>
> On 11/13/2015 01:17 PM, Jingguo Fu wrote:
>> Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
>> ---
>>   framework/dut.py | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/framework/dut.py b/framework/dut.py
>> index 70bd146..37d6050 100644
>> --- a/framework/dut.py
>> +++ b/framework/dut.py
>> @@ -775,12 +775,13 @@ class Dut(Crb):
>>                   port_cfg['source'] = 'cfg'
>>               else:
>>                   port_cfg = {}
>> -
>> -            for key in ['intf', 'mac', 'numa', 'peer', 'source']:
>> +            for key in ['intf', 'mac', 'peer', 'source']:
>>                   if key in port_cfg:
>>                       if key in port and port_cfg[key].lower() != 
>> port[key].lower():
>>                           self.logger.warning("CONFIGURED %s NOT SAME 
>> AS SCANNED!!!" % (key.upper()))
>>                       port[key] = port_cfg[key].lower()
>> +            if 'numa' in port_cfg:
>> +                port['numa'] = port_cfg['numa']
> Better to check whether assigned numa matched detected numa. If they 
> are mismatched, just send out the warning like "mac" and other 
> parameters.
>
>>       def map_available_ports(self):
>>           """
>

  reply	other threads:[~2015-11-23  6:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13  5:17 Jingguo Fu
2015-11-13  6:00 ` Liu, Yong
2015-11-23  6:44   ` Liu, Yong [this message]
2015-11-23  6:52     ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5652B5EA.3020900@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=jingguox.fu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).