From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 7435D8E80
 for <dts@dpdk.org>; Mon, 23 Nov 2015 07:51:41 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 22 Nov 2015 22:51:36 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,336,1444719600"; d="scan'208";a="857664318"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by fmsmga002.fm.intel.com with ESMTP; 22 Nov 2015 22:51:33 -0800
Message-ID: <5652B79E.7040906@intel.com>
Date: Mon, 23 Nov 2015 14:52:14 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Jingguo Fu <jingguox.fu@intel.com>, dts@dpdk.org
References: <1447391834-15200-1-git-send-email-jingguox.fu@intel.com>
 <56457C63.6060600@intel.com> <5652B5EA.3020900@intel.com>
In-Reply-To: <5652B5EA.3020900@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [DTS][PATCH] fix dut port config bug: numa is int,
 does not have lower attr Changes to be committed: modified:
 framework/dut.py
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Nov 2015 06:51:41 -0000

Sorry, tope email. Please ignore this.

On 11/23/2015 02:44 PM, Liu, Yong wrote:
> Applied. Thanks.
>
> On 11/13/2015 02:00 PM, Liu, Yong wrote:
>> Hi Jingguo,
>> Please add warning when configuration not match real. And please 
>> separate comments from email subject.
>>
>> On 11/13/2015 01:17 PM, Jingguo Fu wrote:
>>> Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
>>> ---
>>>   framework/dut.py | 5 +++--
>>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/framework/dut.py b/framework/dut.py
>>> index 70bd146..37d6050 100644
>>> --- a/framework/dut.py
>>> +++ b/framework/dut.py
>>> @@ -775,12 +775,13 @@ class Dut(Crb):
>>>                   port_cfg['source'] = 'cfg'
>>>               else:
>>>                   port_cfg = {}
>>> -
>>> -            for key in ['intf', 'mac', 'numa', 'peer', 'source']:
>>> +            for key in ['intf', 'mac', 'peer', 'source']:
>>>                   if key in port_cfg:
>>>                       if key in port and port_cfg[key].lower() != 
>>> port[key].lower():
>>>                           self.logger.warning("CONFIGURED %s NOT 
>>> SAME AS SCANNED!!!" % (key.upper()))
>>>                       port[key] = port_cfg[key].lower()
>>> +            if 'numa' in port_cfg:
>>> +                port['numa'] = port_cfg['numa']
>> Better to check whether assigned numa matched detected numa. If they 
>> are mismatched, just send out the warning like "mac" and other 
>> parameters.
>>
>>>       def map_available_ports(self):
>>>           """
>>
>