From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id F3F66568A for ; Wed, 2 Dec 2015 02:12:23 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 01 Dec 2015 17:12:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,371,1444719600"; d="scan'208";a="862633527" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by orsmga002.jf.intel.com with ESMTP; 01 Dec 2015 17:12:21 -0800 Message-ID: <565E4561.20203@intel.com> Date: Wed, 02 Dec 2015 09:12:01 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Lijuan Tu , dts@dpdk.org References: <1448956333-2525-1-git-send-email-lijuanx.a.tu@intel.com> In-Reply-To: <1448956333-2525-1-git-send-email-lijuanx.a.tu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH v2]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 01:12:24 -0000 Hi Lijuan, One comment about change rx/tx code path. On 12/01/2015 03:52 PM, Lijuan Tu wrote: > Signed-off-by: Lijuan Tu > --- > tests/TestSuite_uni_pkt.py | 32 +++++++++++++++++++++++++++----- > 1 file changed, 27 insertions(+), 5 deletions(-) > > diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py > index ca72e75..60756c9 100644 > --- a/tests/TestSuite_uni_pkt.py > +++ b/tests/TestSuite_uni_pkt.py > @@ -63,6 +63,17 @@ class TestUniPacket(TestCase): > self.dut_port = valports[0] > tester_port = self.tester.get_local_port(self.dut_port) > self.tester_iface = self.tester.get_interface(tester_port) > + """ > + Change config file to disable vector pmd and recompile the package. > + """ > + [arch, machine, env, toolchain] = self.target.split('-') > + if "fortville" in self.nic.lower(): > + self.dut.send_expect("sed -i -e 's/CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=.*$/" > + + "CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=n/' config/common_%s" % env, "# ", 30) > + elif "niantic" in self.nic.lower(): > + self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=.*$/" > + + "CONFIG_RTE_IXGBE_INC_VECTOR=n/' config/common_%s" % env, "# ", 30) > + self.dut.build_install_dpdk(self.target) > self.dut.send_expect( > "./%s/app/testpmd -c f -n 4 -- -i --txqflags=0x0" % self.target, "testpmd>", 20) > self.dut.send_expect("set fwd rxonly", "testpmd>") > @@ -117,7 +128,7 @@ class TestUniPacket(TestCase): > """ > if "fortville" in self.nic.lower(): > outerL4Type = "(outer) L4 type: L4_NONFRAG" > - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower(): > + elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower(): > outerL4Type = "(outer) L4 type: Unknown" > > pktType = { > @@ -135,7 +146,7 @@ class TestUniPacket(TestCase): > if "fortville" in self.nic.lower(): > pktType.pop("MAC_IPihl_PKT") > pktType.pop("MAC_IPihl_SCTP_PKT") > - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower(): > + elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower(): > pktType.pop("MAC_IP_ICMP_PKT") > pktType.pop("MAC_IPFRAG_TCP_PKT") > > @@ -148,7 +159,7 @@ class TestUniPacket(TestCase): > if "fortville" in self.nic.lower(): > outerL4Type = "(outer) L4 type: L4_NONFRAG" > outerL3Type = "(outer) L3 type: IPV6_EXT_UNKNOWN" > - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower(): > + elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower(): > outerL4Type = "(outer) L4 type: Unknown" > outerL3Type = "(outer) L3 type: IPV6" > > @@ -163,7 +174,7 @@ class TestUniPacket(TestCase): > # delete the unsupported packet based on nic type > if "fortville" in self.nic.lower(): > pktType.pop("MAC_IPv6FRAG_PKT_N") > - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower(): > + elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower(): > pktType.pop("MAC_IPv6FRAG_PKT_F") > > self.run_test(pktType) > @@ -198,7 +209,7 @@ class TestUniPacket(TestCase): > checked that whether IPv4 in IPv6 tunnel packet can be normally > detected by Niantic and i350. > """ > - if "niantic" not in self.nic.lower() and "i350" not in self.nic.lower(): > + if "niantic" not in self.nic.lower() and "powerville" not in self.nic.lower(): > return > > pktType = { > @@ -361,4 +372,15 @@ class TestUniPacket(TestCase): > Nothing to do. > """ > self.dut.kill_all() > + """ > + Restore the config file and recompile the package. > + """ > + [arch, machine, env, toolchain] = self.target.split('-') > + if "fortville" in self.nic.lower(): > + self.dut.send_expect("sed -i -e 's/CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=.*$/" > + + "CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=n/' config/common_%s" % env, "# ", 30) > + elif "niantic" in self.nic.lower(): > + self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=.*$/" > + + "CONFIG_RTE_IXGBE_INC_VECTOR=n/' config/common_%s" % env, "# ", 30) > + self.dut.build_install_dpdk(self.target) Here is still disable vector mode. There's other approach is that use dts.rx_mode which is stripped from execution configuration file. Only when dts.rx_mode is "default" or "vector", this suite need change dpdk configuration. > pass