test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Shijie Dong <shijiex.dong@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] Test loop mirror recovery error
Date: Mon, 07 Dec 2015 09:21:00 +0800	[thread overview]
Message-ID: <5664DEFC.5050903@intel.com> (raw)
In-Reply-To: <1449197233-10114-1-git-send-email-shijiex.dong@intel.com>

Applied. Shijie, please follow dts routine of patch subject. For your 
patch, it should be look like "tests scatter: fix ...".
And your email subject is not match the content of patch, please take 
care of it.

On 12/04/2015 10:47 AM, Shijie Dong wrote:
> From: Dong shijie <shijiex.dong@intel.com>
>
> Reply to the same port two times, one without recovery.
>
> Signed-off-by: Dong shijie <shijiex.dong@intel.com>
> ---
>   tests/TestSuite_scatter.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
> index aab2f9c..ea1e0ee 100644
> --- a/tests/TestSuite_scatter.py
> +++ b/tests/TestSuite_scatter.py
> @@ -94,7 +94,7 @@ class TestScatter(TestCase):
>           time.sleep(5) #wait for scapy capture subprocess exit
>           res = self.get_tcpdump_packet()
>           self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
> -        self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
> +        self.tester.send_expect("ifconfig %s mtu 1500" % rintf, "#")
>           return res
>   
>       def set_up(self):

      reply	other threads:[~2015-12-07  1:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  2:47 Shijie Dong
2015-12-07  1:21 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5664DEFC.5050903@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=shijiex.dong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).