test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: yongjie <yongjiex.gu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH] forcibly remove kni mode in unit test kni
Date: Mon, 07 Dec 2015 09:23:11 +0800	[thread overview]
Message-ID: <5664DF7F.9030506@intel.com> (raw)
In-Reply-To: <1449220481-11071-1-git-send-email-yongjiex.gu@intel.com>

Hi Yongjie,
It look like one bug in kni module, can you check with developer first?

On 12/04/2015 05:14 PM, yongjie wrote:
> From: Gu yongjie <yongjiex.gu@intel.com>
>
> command "rmmod" cannot remove rte_kni on RHEL65 & CentOS6.6.
> And the env will crashed when insmod kni.
> Add "-f" to forcibly remove it.
>
> Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
> ---
>   tests/TestSuite_unit_tests_kni.py |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_kni.py b/tests/TestSuite_unit_tests_kni.py
> index 20df8cc..11cbde7 100644
> --- a/tests/TestSuite_unit_tests_kni.py
> +++ b/tests/TestSuite_unit_tests_kni.py
> @@ -55,7 +55,7 @@ class TestUnitTestsKni(TestCase):
>           out = self.dut.send_expect('lsmod | grep rte_kni', "# ")
>   
>           if "rte_kni" in out:
> -            self.dut.send_expect('rmmod rte_kni.ko', "# ")
> +            self.dut.send_expect('rmmod -f rte_kni.ko', "# ")
>   
>           out = self.dut.send_expect('insmod ./%s/kmod/rte_kni.ko lo_mode=lo_mode_fifo' % (self.target), "# ")
>   
> @@ -103,4 +103,4 @@ class TestUnitTestsKni(TestCase):
>           """
>           Run after each test suite.
>           """
> -        self.dut.send_expect("rmmod rte_kni", "# ", 5)
> +        self.dut.send_expect("rmmod -f rte_kni", "# ", 5)

      reply	other threads:[~2015-12-07  1:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  9:14 yongjie
2015-12-07  1:23 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5664DF7F.9030506@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yongjiex.gu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).