test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH]testSuite kni:enable ipv6 before test
@ 2015-12-08  5:57 Lijuan Tu
  2015-12-10  2:06 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Lijuan Tu @ 2015-12-08  5:57 UTC (permalink / raw)
  To: dts

our test related ipv6 ,so we should enable it.

Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
 tests/TestSuite_kni.py | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
index 69a20fe..d6766a8 100644
--- a/tests/TestSuite_kni.py
+++ b/tests/TestSuite_kni.py
@@ -469,6 +469,8 @@ class TestKni(TestCase):
         for port in self.config['ports']:
             virtual_interface = self.virtual_interface_name(port)
 
+            # enable ipv6
+            self.dut.enable_ipv6(virtual_interface)
             # Set up
             out = self.dut.send_expect(
                 "ifconfig %s up" % virtual_interface, "# ")
@@ -517,6 +519,9 @@ class TestKni(TestCase):
                 "ip -family inet6 address show dev %s" % virtual_interface, "# ")
             self.verify("inet6 addr" not in out, "ifconfig down not supported")
 
+            # restore ipv6 setting
+            self.dut.disable_ipv6(virtual_interface)
+
     def test_ping(self):
         """
         Ping support KNI.
@@ -543,6 +548,9 @@ class TestKni(TestCase):
         # Send ping requests and check for answers
         for port in self.config['ports']:
 
+            # enable ipv6
+            self.dut.enable_ipv6(virtual_interface)
+
             tx_port = self.tester.get_local_port(port)
             tx_interface = self.tester.get_interface(tx_port)
 
@@ -597,6 +605,9 @@ class TestKni(TestCase):
             # remove ip from tester
             self.tester.send_expect(
                  "ip addr del 192.168.%d.2 dev %s" % (port, tx_interface), "# ")
+
+            # restore ipv6 setting
+            self.dut.disable_ipv6(virtual_interface)
           
         for port in self.config['ports']:
             tx_port = self.tester.get_local_port(port)
-- 
1.8.4.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH]testSuite kni:enable ipv6 before test
  2015-12-08  5:57 [dts] [PATCH]testSuite kni:enable ipv6 before test Lijuan Tu
@ 2015-12-10  2:06 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2015-12-10  2:06 UTC (permalink / raw)
  To: Lijuan Tu, dts

Lijuan, the operation on virtual port is not needed. Ipv6 for dut port 
will be enabled as default.
Rejected.

On 12/08/2015 01:57 PM, Lijuan Tu wrote:
> our test related ipv6 ,so we should enable it.
>
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>   tests/TestSuite_kni.py | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
> index 69a20fe..d6766a8 100644
> --- a/tests/TestSuite_kni.py
> +++ b/tests/TestSuite_kni.py
> @@ -469,6 +469,8 @@ class TestKni(TestCase):
>           for port in self.config['ports']:
>               virtual_interface = self.virtual_interface_name(port)
>   
> +            # enable ipv6
> +            self.dut.enable_ipv6(virtual_interface)
>               # Set up
>               out = self.dut.send_expect(
>                   "ifconfig %s up" % virtual_interface, "# ")
> @@ -517,6 +519,9 @@ class TestKni(TestCase):
>                   "ip -family inet6 address show dev %s" % virtual_interface, "# ")
>               self.verify("inet6 addr" not in out, "ifconfig down not supported")
>   
> +            # restore ipv6 setting
> +            self.dut.disable_ipv6(virtual_interface)
> +
>       def test_ping(self):
>           """
>           Ping support KNI.
> @@ -543,6 +548,9 @@ class TestKni(TestCase):
>           # Send ping requests and check for answers
>           for port in self.config['ports']:
>   
> +            # enable ipv6
> +            self.dut.enable_ipv6(virtual_interface)
> +
>               tx_port = self.tester.get_local_port(port)
>               tx_interface = self.tester.get_interface(tx_port)
>   
> @@ -597,6 +605,9 @@ class TestKni(TestCase):
>               # remove ip from tester
>               self.tester.send_expect(
>                    "ip addr del 192.168.%d.2 dev %s" % (port, tx_interface), "# ")
> +
> +            # restore ipv6 setting
> +            self.dut.disable_ipv6(virtual_interface)
>             
>           for port in self.config['ports']:
>               tx_port = self.tester.get_local_port(port)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-10  2:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-08  5:57 [dts] [PATCH]testSuite kni:enable ipv6 before test Lijuan Tu
2015-12-10  2:06 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).