From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 260BD5A4D
 for <dts@dpdk.org>; Thu, 10 Dec 2015 03:06:40 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 09 Dec 2015 18:06:40 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,406,1444719600"; d="scan'208";a="838104540"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by orsmga001.jf.intel.com with ESMTP; 09 Dec 2015 18:06:39 -0800
Message-ID: <5668DE19.7040004@intel.com>
Date: Thu, 10 Dec 2015 10:06:17 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Lijuan Tu <lijuanx.a.tu@intel.com>, dts@dpdk.org
References: <1449554272-51511-1-git-send-email-lijuanx.a.tu@intel.com>
In-Reply-To: <1449554272-51511-1-git-send-email-lijuanx.a.tu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH]testSuite kni:enable ipv6 before test
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Dec 2015 02:06:41 -0000

Lijuan, the operation on virtual port is not needed. Ipv6 for dut port 
will be enabled as default.
Rejected.

On 12/08/2015 01:57 PM, Lijuan Tu wrote:
> our test related ipv6 ,so we should enable it.
>
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>   tests/TestSuite_kni.py | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
> index 69a20fe..d6766a8 100644
> --- a/tests/TestSuite_kni.py
> +++ b/tests/TestSuite_kni.py
> @@ -469,6 +469,8 @@ class TestKni(TestCase):
>           for port in self.config['ports']:
>               virtual_interface = self.virtual_interface_name(port)
>   
> +            # enable ipv6
> +            self.dut.enable_ipv6(virtual_interface)
>               # Set up
>               out = self.dut.send_expect(
>                   "ifconfig %s up" % virtual_interface, "# ")
> @@ -517,6 +519,9 @@ class TestKni(TestCase):
>                   "ip -family inet6 address show dev %s" % virtual_interface, "# ")
>               self.verify("inet6 addr" not in out, "ifconfig down not supported")
>   
> +            # restore ipv6 setting
> +            self.dut.disable_ipv6(virtual_interface)
> +
>       def test_ping(self):
>           """
>           Ping support KNI.
> @@ -543,6 +548,9 @@ class TestKni(TestCase):
>           # Send ping requests and check for answers
>           for port in self.config['ports']:
>   
> +            # enable ipv6
> +            self.dut.enable_ipv6(virtual_interface)
> +
>               tx_port = self.tester.get_local_port(port)
>               tx_interface = self.tester.get_interface(tx_port)
>   
> @@ -597,6 +605,9 @@ class TestKni(TestCase):
>               # remove ip from tester
>               self.tester.send_expect(
>                    "ip addr del 192.168.%d.2 dev %s" % (port, tx_interface), "# ")
> +
> +            # restore ipv6 setting
> +            self.dut.disable_ipv6(virtual_interface)
>             
>           for port in self.config['ports']:
>               tx_port = self.tester.get_local_port(port)