test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: haifeng <haifengx.tang@intel.com>, dts@dpdk.org
Subject: Re: [dts] [DTS][PATCH] change ringpmd test method , remove attach option
Date: Fri, 22 Jan 2016 17:15:09 +0800	[thread overview]
Message-ID: <56A1F31D.1050204@intel.com> (raw)
In-Reply-To: <1453452987-4261-1-git-send-email-haifengx.tang@intel.com>

Applied with more comments.

On 01/22/2016 04:56 PM, haifeng wrote:
> Signed-off-by: haifeng <haifengx.tang@intel.com>
> ---
>   test_plans/unit_tests_ringpmd_test_plan.rst | 3 +--
>   tests/TestSuite_unit_tests_ringpmd.py       | 6 +-----
>   2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/test_plans/unit_tests_ringpmd_test_plan.rst b/test_plans/unit_tests_ringpmd_test_plan.rst
> index 18f780c..31f703b 100644
> --- a/test_plans/unit_tests_ringpmd_test_plan.rst
> +++ b/test_plans/unit_tests_ringpmd_test_plan.rst
> @@ -53,8 +53,7 @@ The steps to run the unit test manually are as follow::
>     
>     # make -C ./app/test/
>     # ./app/test/test -n 1 -c ffff --vdev='eth_ring0,nodeaction=:0:CREATE'
> -     --vdev='eth_ring0,nodeaction=:0:ATTACH' --vdev='eth_ring1,nodeaction=:0:CREATE'
> -     --vdev='eth ring2,nodeaction=:0:CREATE' --vdev='eth_ring2,nodeaction=:0:ATTACH'
> +      --vdev='eth_ring1,nodeaction=:0:CREATE'  --vdev='eth ring2,nodeaction=:0:CREATE'
>     RTE>> ring_pmd_autotest
>   
>   The final output of the test has to be "Test OK"
> diff --git a/tests/TestSuite_unit_tests_ringpmd.py b/tests/TestSuite_unit_tests_ringpmd.py
> index 7f88482..39d85b0 100644
> --- a/tests/TestSuite_unit_tests_ringpmd.py
> +++ b/tests/TestSuite_unit_tests_ringpmd.py
> @@ -58,10 +58,8 @@ class TestUnitTestsRingPmd(TestCase):
>           Nothing to do here.
>           """
>           self.ring_ports = [{'mode': 'tx', 'index': '0'},
> -                           {'mode': 'rx', 'index': '0'},
>                              {'mode': 'rxtx', 'index': '1'},
> -                           {'mode': 'tx', 'index': '2'},
> -                           {'mode': 'rx', 'index': '2'}]
> +                           {'mode': 'tx', 'index': '2'}]
>   
>       def set_up(self):
>           """
> @@ -78,8 +76,6 @@ class TestUnitTestsRingPmd(TestCase):
>           for port in self.ring_ports:
>               if port['mode'] == 'tx':
>                   dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index']
> -            elif port['mode'] == 'rx':
> -                dev_str += "--vdev='eth_ring%s,nodeaction=:0:ATTACH' " % port['index']
>               else:
>                   dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index']
>   

      reply	other threads:[~2016-01-22  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22  8:56 haifeng
2016-01-22  9:15 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A1F31D.1050204@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=haifengx.tang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).