From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 74F7591A0 for ; Fri, 22 Jan 2016 10:13:00 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 22 Jan 2016 01:12:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,330,1449561600"; d="scan'208";a="898731469" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by fmsmga002.fm.intel.com with ESMTP; 22 Jan 2016 01:12:58 -0800 Message-ID: <56A1F31D.1050204@intel.com> Date: Fri, 22 Jan 2016 17:15:09 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: haifeng , dts@dpdk.org References: <1453452987-4261-1-git-send-email-haifengx.tang@intel.com> In-Reply-To: <1453452987-4261-1-git-send-email-haifengx.tang@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [DTS][PATCH] change ringpmd test method , remove attach option X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2016 09:13:00 -0000 Applied with more comments. On 01/22/2016 04:56 PM, haifeng wrote: > Signed-off-by: haifeng > --- > test_plans/unit_tests_ringpmd_test_plan.rst | 3 +-- > tests/TestSuite_unit_tests_ringpmd.py | 6 +----- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/test_plans/unit_tests_ringpmd_test_plan.rst b/test_plans/unit_tests_ringpmd_test_plan.rst > index 18f780c..31f703b 100644 > --- a/test_plans/unit_tests_ringpmd_test_plan.rst > +++ b/test_plans/unit_tests_ringpmd_test_plan.rst > @@ -53,8 +53,7 @@ The steps to run the unit test manually are as follow:: > > # make -C ./app/test/ > # ./app/test/test -n 1 -c ffff --vdev='eth_ring0,nodeaction=:0:CREATE' > - --vdev='eth_ring0,nodeaction=:0:ATTACH' --vdev='eth_ring1,nodeaction=:0:CREATE' > - --vdev='eth ring2,nodeaction=:0:CREATE' --vdev='eth_ring2,nodeaction=:0:ATTACH' > + --vdev='eth_ring1,nodeaction=:0:CREATE' --vdev='eth ring2,nodeaction=:0:CREATE' > RTE>> ring_pmd_autotest > > The final output of the test has to be "Test OK" > diff --git a/tests/TestSuite_unit_tests_ringpmd.py b/tests/TestSuite_unit_tests_ringpmd.py > index 7f88482..39d85b0 100644 > --- a/tests/TestSuite_unit_tests_ringpmd.py > +++ b/tests/TestSuite_unit_tests_ringpmd.py > @@ -58,10 +58,8 @@ class TestUnitTestsRingPmd(TestCase): > Nothing to do here. > """ > self.ring_ports = [{'mode': 'tx', 'index': '0'}, > - {'mode': 'rx', 'index': '0'}, > {'mode': 'rxtx', 'index': '1'}, > - {'mode': 'tx', 'index': '2'}, > - {'mode': 'rx', 'index': '2'}] > + {'mode': 'tx', 'index': '2'}] > > def set_up(self): > """ > @@ -78,8 +76,6 @@ class TestUnitTestsRingPmd(TestCase): > for port in self.ring_ports: > if port['mode'] == 'tx': > dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index'] > - elif port['mode'] == 'rx': > - dev_str += "--vdev='eth_ring%s,nodeaction=:0:ATTACH' " % port['index'] > else: > dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index'] >