test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [DTS][PATCH 1/2] update cmdline test plan for parameter change update unit test plan: for cmdline, objtest -> object
@ 2016-02-03  7:17 Jingguo Fu
  2016-02-03  7:17 ` [dts] [DTS][PATCH 2/2] fix cmdline test case for parameter change update unit test case: " Jingguo Fu
  2016-02-03  8:43 ` [dts] [DTS][PATCH 1/2] update cmdline test plan for parameter change update unit test plan: " Liu, Yong
  0 siblings, 2 replies; 3+ messages in thread
From: Jingguo Fu @ 2016-02-03  7:17 UTC (permalink / raw)
  To: dts; +Cc: Jingguo Fu

Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
---
 test_plans/cmdline_test_plan.rst | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/test_plans/cmdline_test_plan.rst b/test_plans/cmdline_test_plan.rst
index 3ab9be3..76b24bf 100644
--- a/test_plans/cmdline_test_plan.rst
+++ b/test_plans/cmdline_test_plan.rst
@@ -76,34 +76,34 @@ Test Case: cmdline sample commands test
 
 Add a test object with an IP address associated to it::
     
-  example>add objtest 192.168.0.1
-    Object objtest added, ip=192.168.0.1 
+  example>add object 192.168.0.1
+    Object object added, ip=192.168.0.1 
 
 Verify the object existance::
         
-  example>add objtest 192.168.0.1
-    Object objtest already exist
+  example>add object 192.168.0.1
+    Object object already exist
 
 Show the object result by ``show`` command::
   
-  example>show objtest
-    Object objtest, ip=192.168.0.1
+  example>show object
+    Object object, ip=192.168.0.1
 
 Verify the output matchs the confiuration.
 
 Delete the object in cmdline and show the result again::
         
-  example>del objtest
-    Object objtest removed, ip=192.168.0.1
+  example>del object
+    Object object removed, ip=192.168.0.1
 
 Double delete the object to verify the correctness::
   
-  example>del objtest
+  example>del object
     Bad arguments
 
 Verify no such object exist now.::
 
-  example>show objtest
+  example>show object
     Bad arguments
 
 Verify the hidden command ? and help command::
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [DTS][PATCH 2/2] fix cmdline test case for parameter change update unit test case: for cmdline, objtest -> object
  2016-02-03  7:17 [dts] [DTS][PATCH 1/2] update cmdline test plan for parameter change update unit test plan: for cmdline, objtest -> object Jingguo Fu
@ 2016-02-03  7:17 ` Jingguo Fu
  2016-02-03  8:43 ` [dts] [DTS][PATCH 1/2] update cmdline test plan for parameter change update unit test plan: " Liu, Yong
  1 sibling, 0 replies; 3+ messages in thread
From: Jingguo Fu @ 2016-02-03  7:17 UTC (permalink / raw)
  To: dts; +Cc: Jingguo Fu

Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
---
 tests/TestSuite_cmdline.py | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_cmdline.py b/tests/TestSuite_cmdline.py
index e1496f9..13b0e63 100644
--- a/tests/TestSuite_cmdline.py
+++ b/tests/TestSuite_cmdline.py
@@ -73,27 +73,27 @@ class TestCmdline(TestCase):
         """
 
         # add a test object with an IP address associated
-        out = self.dut.send_expect("add objtest 192.168.0.1", "example> ")
-        self.verify("Object objtest added, ip=192.168.0.1" in out, "add command error")
+        out = self.dut.send_expect("add object 192.168.0.1", "example> ")
+        self.verify("Object object added, ip=192.168.0.1" in out, "add command error")
 
         # verify the object existance
-        out = self.dut.send_expect("add objtest 192.168.0.1", "example> ")
-        self.verify("Object objtest already exist" in out, "double add command error")
+        out = self.dut.send_expect("add object 192.168.0.1", "example> ")
+        self.verify("Object object already exist" in out, "double add command error")
 
         # show the object result by 'show' command
-        out = self.dut.send_expect("show objtest", "example> ")
-        self.verify("Object objtest, ip=192.168.0.1" in out, "show command error")
+        out = self.dut.send_expect("show object", "example> ")
+        self.verify("Object object, ip=192.168.0.1" in out, "show command error")
 
         # delete the object in cmdline
-        out = self.dut.send_expect("del objtest", "example> ")
-        self.verify("Object objtest removed, ip=192.168.0.1" in out, "del command error")
+        out = self.dut.send_expect("del object", "example> ")
+        self.verify("Object object removed, ip=192.168.0.1" in out, "del command error")
 
         # double delete the object to verify the correctness
-        out = self.dut.send_expect("del objtest", "example> ", 1)
+        out = self.dut.send_expect("del object", "example> ", 1)
         self.verify("Bad arguments" in out, "double del command error")
 
         # verify no such object anymore
-        out = self.dut.send_expect("show objtest", "example> ", 1)
+        out = self.dut.send_expect("show object", "example> ", 1)
         self.verify("Bad arguments" in out, "final show command error")
 
         # verify the help command
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [DTS][PATCH 1/2] update cmdline test plan for parameter change update unit test plan: for cmdline, objtest -> object
  2016-02-03  7:17 [dts] [DTS][PATCH 1/2] update cmdline test plan for parameter change update unit test plan: for cmdline, objtest -> object Jingguo Fu
  2016-02-03  7:17 ` [dts] [DTS][PATCH 2/2] fix cmdline test case for parameter change update unit test case: " Jingguo Fu
@ 2016-02-03  8:43 ` Liu, Yong
  1 sibling, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2016-02-03  8:43 UTC (permalink / raw)
  To: Jingguo Fu, dts

Applied, please separate git commit log and git commit title. Email 
subject should be small and easy to read.

On 02/03/2016 03:17 PM, Jingguo Fu wrote:
> Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
> ---
>   test_plans/cmdline_test_plan.rst | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/test_plans/cmdline_test_plan.rst b/test_plans/cmdline_test_plan.rst
> index 3ab9be3..76b24bf 100644
> --- a/test_plans/cmdline_test_plan.rst
> +++ b/test_plans/cmdline_test_plan.rst
> @@ -76,34 +76,34 @@ Test Case: cmdline sample commands test
>   
>   Add a test object with an IP address associated to it::
>       
> -  example>add objtest 192.168.0.1
> -    Object objtest added, ip=192.168.0.1
> +  example>add object 192.168.0.1
> +    Object object added, ip=192.168.0.1
>   
>   Verify the object existance::
>           
> -  example>add objtest 192.168.0.1
> -    Object objtest already exist
> +  example>add object 192.168.0.1
> +    Object object already exist
>   
>   Show the object result by ``show`` command::
>     
> -  example>show objtest
> -    Object objtest, ip=192.168.0.1
> +  example>show object
> +    Object object, ip=192.168.0.1
>   
>   Verify the output matchs the confiuration.
>   
>   Delete the object in cmdline and show the result again::
>           
> -  example>del objtest
> -    Object objtest removed, ip=192.168.0.1
> +  example>del object
> +    Object object removed, ip=192.168.0.1
>   
>   Double delete the object to verify the correctness::
>     
> -  example>del objtest
> +  example>del object
>       Bad arguments
>   
>   Verify no such object exist now.::
>   
> -  example>show objtest
> +  example>show object
>       Bad arguments
>   
>   Verify the hidden command ? and help command::

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-03  8:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-03  7:17 [dts] [DTS][PATCH 1/2] update cmdline test plan for parameter change update unit test plan: for cmdline, objtest -> object Jingguo Fu
2016-02-03  7:17 ` [dts] [DTS][PATCH 2/2] fix cmdline test case for parameter change update unit test case: " Jingguo Fu
2016-02-03  8:43 ` [dts] [DTS][PATCH 1/2] update cmdline test plan for parameter change update unit test plan: " Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).