[dts] [PATCH]tests vf_packet_rxtx: turn on crc-strip

[dts] [PATCH]tests vf_packet_rxtx: turn on crc-strip

[Lijuan Tu]

kernel driver turn on crc-strip as default

Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
 tests/TestSuite_vf_packet_rxtx.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/TestSuite_vf_packet_rxtx.py b/tests/TestSuite_vf_packet_rxtx.py
index def7816..a632a44 100644
--- a/tests/TestSuite_vf_packet_rxtx.py
+++ b/tests/TestSuite_vf_packet_rxtx.py
@@ -110,6 +110,9 @@ class TestVfPacketRxtx(TestCase):
         port_id_0 = 0
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
+        self.vm0_testpmd.execute_cmd('port stop all')
+        self.vm0_testpmd.execute_cmd('port config all crc-strip on')
+        self.vm0_testpmd.execute_cmd('port start all')
         self.vm0_testpmd.execute_cmd('show port info all')
         pmd_vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
         self.vm0_testpmd.execute_cmd('set fwd mac')
-- 
2.5.0

Re: [dts] [PATCH]tests vf_packet_rxtx: turn on crc-strip

[Pei, Yulong]

Ack+

-----Original Message-----
From: Tu, LijuanX A 
Sent: Friday, February 26, 2016 2:58 PM
To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org; Pei, Yulong <yulong.pei@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>
Cc: Tu, LijuanX A <lijuanx.a.tu@intel.com>
Subject: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip

kernel driver turn on crc-strip as default

Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
 tests/TestSuite_vf_packet_rxtx.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/TestSuite_vf_packet_rxtx.py b/tests/TestSuite_vf_packet_rxtx.py
index def7816..a632a44 100644
--- a/tests/TestSuite_vf_packet_rxtx.py
+++ b/tests/TestSuite_vf_packet_rxtx.py
@@ -110,6 +110,9 @@ class TestVfPacketRxtx(TestCase):
         port_id_0 = 0
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
+        self.vm0_testpmd.execute_cmd('port stop all')
+        self.vm0_testpmd.execute_cmd('port config all crc-strip on')
+        self.vm0_testpmd.execute_cmd('port start all')
         self.vm0_testpmd.execute_cmd('show port info all')
         pmd_vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
         self.vm0_testpmd.execute_cmd('set fwd mac')
-- 
2.5.0

Re: [dts] [PATCH]tests vf_packet_rxtx: turn on crc-strip

[Liu, Yong]

Hi Lijuan, I remember only FVL PF driver enable crc-strip by default. Please correct if I'm wrong.

> -----Original Message-----
> From: Pei, Yulong
> Sent: Friday, February 26, 2016 3:37 PM
> To: Tu, LijuanX A; Liu, Yong; dts@dpdk.org; Xu, Qian Q
> Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> 
> Ack+
> 
> -----Original Message-----
> From: Tu, LijuanX A
> Sent: Friday, February 26, 2016 2:58 PM
> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org; Pei, Yulong
> <yulong.pei@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>
> Cc: Tu, LijuanX A <lijuanx.a.tu@intel.com>
> Subject: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> 
> kernel driver turn on crc-strip as default
> 
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>  tests/TestSuite_vf_packet_rxtx.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/TestSuite_vf_packet_rxtx.py
> b/tests/TestSuite_vf_packet_rxtx.py
> index def7816..a632a44 100644
> --- a/tests/TestSuite_vf_packet_rxtx.py
> +++ b/tests/TestSuite_vf_packet_rxtx.py
> @@ -110,6 +110,9 @@ class TestVfPacketRxtx(TestCase):
>          port_id_0 = 0
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
>          self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> +        self.vm0_testpmd.execute_cmd('port stop all')
> +        self.vm0_testpmd.execute_cmd('port config all crc-strip on')
> +        self.vm0_testpmd.execute_cmd('port start all')
>          self.vm0_testpmd.execute_cmd('show port info all')
>          pmd_vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
>          self.vm0_testpmd.execute_cmd('set fwd mac')
> --
> 2.5.0

Re: [dts] [PATCH]tests vf_packet_rxtx: turn on crc-strip

[Xu, Qian Q]

In my mind, all ixgbe pf crc default enabled

发自我的 iPhone

> 在 2016年2月28日，下午8:45，Liu, Yong <yong.liu@intel.com> 写道：
> 
> Hi Lijuan, I remember only FVL PF driver enable crc-strip by default. Please correct if I'm wrong.
> 
>> -----Original Message-----
>> From: Pei, Yulong
>> Sent: Friday, February 26, 2016 3:37 PM
>> To: Tu, LijuanX A; Liu, Yong; dts@dpdk.org; Xu, Qian Q
>> Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
>> 
>> Ack+
>> 
>> -----Original Message-----
>> From: Tu, LijuanX A
>> Sent: Friday, February 26, 2016 2:58 PM
>> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org; Pei, Yulong
>> <yulong.pei@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>
>> Cc: Tu, LijuanX A <lijuanx.a.tu@intel.com>
>> Subject: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
>> 
>> kernel driver turn on crc-strip as default
>> 
>> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
>> ---
>> tests/TestSuite_vf_packet_rxtx.py | 3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/tests/TestSuite_vf_packet_rxtx.py
>> b/tests/TestSuite_vf_packet_rxtx.py
>> index def7816..a632a44 100644
>> --- a/tests/TestSuite_vf_packet_rxtx.py
>> +++ b/tests/TestSuite_vf_packet_rxtx.py
>> @@ -110,6 +110,9 @@ class TestVfPacketRxtx(TestCase):
>>         port_id_0 = 0
>>         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
>>         self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
>> +        self.vm0_testpmd.execute_cmd('port stop all')
>> +        self.vm0_testpmd.execute_cmd('port config all crc-strip on')
>> +        self.vm0_testpmd.execute_cmd('port start all')
>>         self.vm0_testpmd.execute_cmd('show port info all')
>>         pmd_vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
>>         self.vm0_testpmd.execute_cmd('set fwd mac')
>> --
>> 2.5.0
> 

Re: [dts] [PATCH]tests vf_packet_rxtx: turn on crc-strip

[Tu, LijuanX A]

Hi Yong,
	I have talk about crc-strip with Qian , and we think "set crc-strip on" is no harm.

> -----Original Message-----
> From: Liu, Yong
> Sent: Sunday, February 28, 2016 8:45 PM
> To: Pei, Yulong; Tu, LijuanX A; dts@dpdk.org; Xu, Qian Q
> Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> 
> Hi Lijuan, I remember only FVL PF driver enable crc-strip by default.
> Please correct if I'm wrong.
> 
> > -----Original Message-----
> > From: Pei, Yulong
> > Sent: Friday, February 26, 2016 3:37 PM
> > To: Tu, LijuanX A; Liu, Yong; dts@dpdk.org; Xu, Qian Q
> > Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> >
> > Ack+
> >
> > -----Original Message-----
> > From: Tu, LijuanX A
> > Sent: Friday, February 26, 2016 2:58 PM
> > To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org; Pei, Yulong
> > <yulong.pei@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>
> > Cc: Tu, LijuanX A <lijuanx.a.tu@intel.com>
> > Subject: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> >
> > kernel driver turn on crc-strip as default
> >
> > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> > ---
> >  tests/TestSuite_vf_packet_rxtx.py | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/TestSuite_vf_packet_rxtx.py
> > b/tests/TestSuite_vf_packet_rxtx.py
> > index def7816..a632a44 100644
> > --- a/tests/TestSuite_vf_packet_rxtx.py
> > +++ b/tests/TestSuite_vf_packet_rxtx.py
> > @@ -110,6 +110,9 @@ class TestVfPacketRxtx(TestCase):
> >          port_id_0 = 0
> >          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
> >          self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> > +        self.vm0_testpmd.execute_cmd('port stop all')
> > +        self.vm0_testpmd.execute_cmd('port config all crc-strip on')
> > +        self.vm0_testpmd.execute_cmd('port start all')
> >          self.vm0_testpmd.execute_cmd('show port info all')
> >          pmd_vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
> >          self.vm0_testpmd.execute_cmd('set fwd mac')
> > --
> > 2.5.0

Re: [dts] [PATCH]tests vf_packet_rxtx: turn on crc-strip

[Xu, Qian Q]

Yes

Thanks
Qian

-----Original Message-----
From: Tu, LijuanX A 
Sent: Monday, February 29, 2016 2:50 PM
To: Liu, Yong; Pei, Yulong; dts@dpdk.org; Xu, Qian Q
Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip

Hi Yong,
	I have talk about crc-strip with Qian , and we think "set crc-strip on" is no harm.

> -----Original Message-----
> From: Liu, Yong
> Sent: Sunday, February 28, 2016 8:45 PM
> To: Pei, Yulong; Tu, LijuanX A; dts@dpdk.org; Xu, Qian Q
> Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> 
> Hi Lijuan, I remember only FVL PF driver enable crc-strip by default.
> Please correct if I'm wrong.
> 
> > -----Original Message-----
> > From: Pei, Yulong
> > Sent: Friday, February 26, 2016 3:37 PM
> > To: Tu, LijuanX A; Liu, Yong; dts@dpdk.org; Xu, Qian Q
> > Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> >
> > Ack+
> >
> > -----Original Message-----
> > From: Tu, LijuanX A
> > Sent: Friday, February 26, 2016 2:58 PM
> > To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org; Pei, Yulong 
> > <yulong.pei@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>
> > Cc: Tu, LijuanX A <lijuanx.a.tu@intel.com>
> > Subject: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> >
> > kernel driver turn on crc-strip as default
> >
> > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> > ---
> >  tests/TestSuite_vf_packet_rxtx.py | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/TestSuite_vf_packet_rxtx.py
> > b/tests/TestSuite_vf_packet_rxtx.py
> > index def7816..a632a44 100644
> > --- a/tests/TestSuite_vf_packet_rxtx.py
> > +++ b/tests/TestSuite_vf_packet_rxtx.py
> > @@ -110,6 +110,9 @@ class TestVfPacketRxtx(TestCase):
> >          port_id_0 = 0
> >          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
> >          self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> > +        self.vm0_testpmd.execute_cmd('port stop all')
> > +        self.vm0_testpmd.execute_cmd('port config all crc-strip on')
> > +        self.vm0_testpmd.execute_cmd('port start all')
> >          self.vm0_testpmd.execute_cmd('show port info all')
> >          pmd_vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
> >          self.vm0_testpmd.execute_cmd('set fwd mac')
> > --
> > 2.5.0

Re: [dts] [PATCH]tests vf_packet_rxtx: turn on crc-strip

[Liu, Yong]

Thanks all, applied.

On 02/29/2016 02:49 PM, Xu, Qian Q wrote:
> Yes
>
> Thanks
> Qian
>
> -----Original Message-----
> From: Tu, LijuanX A
> Sent: Monday, February 29, 2016 2:50 PM
> To: Liu, Yong; Pei, Yulong; dts@dpdk.org; Xu, Qian Q
> Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
>
> Hi Yong,
> 	I have talk about crc-strip with Qian , and we think "set crc-strip on" is no harm.
>
>> -----Original Message-----
>> From: Liu, Yong
>> Sent: Sunday, February 28, 2016 8:45 PM
>> To: Pei, Yulong; Tu, LijuanX A; dts@dpdk.org; Xu, Qian Q
>> Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
>>
>> Hi Lijuan, I remember only FVL PF driver enable crc-strip by default.
>> Please correct if I'm wrong.
>>
>>> -----Original Message-----
>>> From: Pei, Yulong
>>> Sent: Friday, February 26, 2016 3:37 PM
>>> To: Tu, LijuanX A; Liu, Yong; dts@dpdk.org; Xu, Qian Q
>>> Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
>>>
>>> Ack+
>>>
>>> -----Original Message-----
>>> From: Tu, LijuanX A
>>> Sent: Friday, February 26, 2016 2:58 PM
>>> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org; Pei, Yulong
>>> <yulong.pei@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>
>>> Cc: Tu, LijuanX A <lijuanx.a.tu@intel.com>
>>> Subject: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
>>>
>>> kernel driver turn on crc-strip as default
>>>
>>> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
>>> ---
>>>   tests/TestSuite_vf_packet_rxtx.py | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/tests/TestSuite_vf_packet_rxtx.py
>>> b/tests/TestSuite_vf_packet_rxtx.py
>>> index def7816..a632a44 100644
>>> --- a/tests/TestSuite_vf_packet_rxtx.py
>>> +++ b/tests/TestSuite_vf_packet_rxtx.py
>>> @@ -110,6 +110,9 @@ class TestVfPacketRxtx(TestCase):
>>>           port_id_0 = 0
>>>           self.vm0_testpmd = PmdOutput(self.vm_dut_0)
>>>           self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
>>> +        self.vm0_testpmd.execute_cmd('port stop all')
>>> +        self.vm0_testpmd.execute_cmd('port config all crc-strip on')
>>> +        self.vm0_testpmd.execute_cmd('port start all')
>>>           self.vm0_testpmd.execute_cmd('show port info all')
>>>           pmd_vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
>>>           self.vm0_testpmd.execute_cmd('set fwd mac')
>>> --
>>> 2.5.0