test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>, dts <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework: fix lscpu parsing for numa id instead of phy socket id
Date: Fri, 18 Mar 2016 15:31:35 +0800	[thread overview]
Message-ID: <56EBAED7.7070404@intel.com> (raw)
In-Reply-To: <1458214421-9768-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com>

Thanks, applied in next branch.

On 03/17/2016 07:33 PM, Gowrishankar wrote:
> From: Gowri Shankar <gowrishankar.m@linux.vnet.ibm.com>
>
> NIC ports associate with numa node number, as our tests parse sysfs for their
> ports. In recent patch on CPU info parsing, lscpu -p was used to prepare cores
> list in which, socket ID column was used for phy socket. Ideally it should have
> been numa column which our tests look for (eg, pmd test).
>
> Signed-off-by: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
> ---
>   framework/crb.py |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/crb.py b/framework/crb.py
> index 33ceb8c..3194f69 100644
> --- a/framework/crb.py
> +++ b/framework/crb.py
> @@ -504,7 +504,7 @@ class Crb(object):
>           core_id = 0
>           coremap = {}
>           for line in cpuinfo:
> -            (thread, core, socket) = line.split(',')[0:3]
> +            (thread, core, unused, socket) = line.split(',')[0:4]
>   
>               if core not in coremap.keys():
>                   coremap[core] = core_id

      reply	other threads:[~2016-03-18  7:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 11:33 Gowrishankar
2016-03-18  7:31 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EBAED7.7070404@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gowrishankar.m@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).