From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id E229E5902
 for <dts@dpdk.org>; Fri, 18 Mar 2016 08:30:50 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 18 Mar 2016 00:30:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,353,1455004800"; d="scan'208";a="766628132"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by orsmga003.jf.intel.com with ESMTP; 18 Mar 2016 00:30:24 -0700
Message-ID: <56EBAED7.7070404@intel.com>
Date: Fri, 18 Mar 2016 15:31:35 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>, dts <dts@dpdk.org>
References: <1458214421-9768-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com>
In-Reply-To: <1458214421-9768-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH] framework: fix lscpu parsing for numa id instead
 of phy socket id
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Mar 2016 07:30:51 -0000

Thanks, applied in next branch.

On 03/17/2016 07:33 PM, Gowrishankar wrote:
> From: Gowri Shankar <gowrishankar.m@linux.vnet.ibm.com>
>
> NIC ports associate with numa node number, as our tests parse sysfs for their
> ports. In recent patch on CPU info parsing, lscpu -p was used to prepare cores
> list in which, socket ID column was used for phy socket. Ideally it should have
> been numa column which our tests look for (eg, pmd test).
>
> Signed-off-by: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
> ---
>   framework/crb.py |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/crb.py b/framework/crb.py
> index 33ceb8c..3194f69 100644
> --- a/framework/crb.py
> +++ b/framework/crb.py
> @@ -504,7 +504,7 @@ class Crb(object):
>           core_id = 0
>           coremap = {}
>           for line in cpuinfo:
> -            (thread, core, socket) = line.split(',')[0:3]
> +            (thread, core, unused, socket) = line.split(',')[0:4]
>   
>               if core not in coremap.keys():
>                   coremap[core] = core_id