* [dts] [PATCH] framework: fix lscpu parsing for numa id instead of phy socket id
@ 2016-03-17 11:33 Gowrishankar
2016-03-18 7:31 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: Gowrishankar @ 2016-03-17 11:33 UTC (permalink / raw)
To: dts; +Cc: Gowri Shankar
From: Gowri Shankar <gowrishankar.m@linux.vnet.ibm.com>
NIC ports associate with numa node number, as our tests parse sysfs for their
ports. In recent patch on CPU info parsing, lscpu -p was used to prepare cores
list in which, socket ID column was used for phy socket. Ideally it should have
been numa column which our tests look for (eg, pmd test).
Signed-off-by: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
---
framework/crb.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/framework/crb.py b/framework/crb.py
index 33ceb8c..3194f69 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -504,7 +504,7 @@ class Crb(object):
core_id = 0
coremap = {}
for line in cpuinfo:
- (thread, core, socket) = line.split(',')[0:3]
+ (thread, core, unused, socket) = line.split(',')[0:4]
if core not in coremap.keys():
coremap[core] = core_id
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dts] [PATCH] framework: fix lscpu parsing for numa id instead of phy socket id
2016-03-17 11:33 [dts] [PATCH] framework: fix lscpu parsing for numa id instead of phy socket id Gowrishankar
@ 2016-03-18 7:31 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2016-03-18 7:31 UTC (permalink / raw)
To: Gowrishankar, dts
Thanks, applied in next branch.
On 03/17/2016 07:33 PM, Gowrishankar wrote:
> From: Gowri Shankar <gowrishankar.m@linux.vnet.ibm.com>
>
> NIC ports associate with numa node number, as our tests parse sysfs for their
> ports. In recent patch on CPU info parsing, lscpu -p was used to prepare cores
> list in which, socket ID column was used for phy socket. Ideally it should have
> been numa column which our tests look for (eg, pmd test).
>
> Signed-off-by: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
> ---
> framework/crb.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/crb.py b/framework/crb.py
> index 33ceb8c..3194f69 100644
> --- a/framework/crb.py
> +++ b/framework/crb.py
> @@ -504,7 +504,7 @@ class Crb(object):
> core_id = 0
> coremap = {}
> for line in cpuinfo:
> - (thread, core, socket) = line.split(',')[0:3]
> + (thread, core, unused, socket) = line.split(',')[0:4]
>
> if core not in coremap.keys():
> coremap[core] = core_id
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-18 7:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-17 11:33 [dts] [PATCH] framework: fix lscpu parsing for numa id instead of phy socket id Gowrishankar
2016-03-18 7:31 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).