test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [dts 1/2]i[PATCH V2] update ixgbe nic tpid command
Date: Fri, 18 Mar 2016 15:35:41 +0800	[thread overview]
Message-ID: <56EBAFCD.4040900@intel.com> (raw)
In-Reply-To: <1458285577-93421-1-git-send-email-huilongx.xu@intel.com>

Thanks, applied with commit modified.

On 03/18/2016 03:19 PM, xu,huilong wrote:
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_dual_vlan.py | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
> index 84552f5..a4ae23e 100644
> --- a/tests/TestSuite_dual_vlan.py
> +++ b/tests/TestSuite_dual_vlan.py
> @@ -364,14 +364,15 @@ class TestDualVlan(TestCase):
>           self.verify(self.nic not in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "hartwell"], "%s NIC not support tcpid " % self.nic)
>   
>           self.mode_config(filter="on", strip="on", qinq="on")
> -        self.dut.send_expect("vlan set tpid 1234 %s" % dutRxPortId, "testpmd> ")
> +        # nic only support inner model, except fortville nic
> +        self.dut.send_expect("vlan set inner tpid 1234 %s" % dutRxPortId, "testpmd> ")
>           self.vlan_send_packet(outvlan, invlan)
>   
>           out = self.get_tcpdump_package()
>           self.verify("vlan %s" % outvlan in out, "vlan tpid disable error: " + out)
>           self.verify("vlan %s" % invlan in out, "vlan tpid disable error: " + out)
>   
> -        self.dut.send_expect("vlan set tpid 0x8100 %s" % dutRxPortId, "testpmd> ")
> +        self.dut.send_expect("vlan set inner tpid 0x8100 %s" % dutRxPortId, "testpmd> ")
>           self.vlan_send_packet(outvlan, invlan)
>   
>           out = self.get_tcpdump_package()

      parent reply	other threads:[~2016-03-18  7:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18  7:19 xu,huilong
2016-03-18  7:19 ` [dts] [dts 2/2][PATCH V2] update dual vlan tpid test plan xu,huilong
2016-03-18  7:35 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EBAFCD.4040900@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).