From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id AE0F95908
 for <dts@dpdk.org>; Fri, 18 Mar 2016 08:34:36 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 18 Mar 2016 00:34:35 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,353,1455004800"; d="scan'208";a="913695136"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by orsmga001.jf.intel.com with ESMTP; 18 Mar 2016 00:34:31 -0700
Message-ID: <56EBAFCD.4040900@intel.com>
Date: Fri, 18 Mar 2016 15:35:41 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
References: <1458285577-93421-1-git-send-email-huilongx.xu@intel.com>
In-Reply-To: <1458285577-93421-1-git-send-email-huilongx.xu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [dts 1/2]i[PATCH V2] update ixgbe nic tpid command
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Mar 2016 07:34:37 -0000

Thanks, applied with commit modified.

On 03/18/2016 03:19 PM, xu,huilong wrote:
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_dual_vlan.py | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
> index 84552f5..a4ae23e 100644
> --- a/tests/TestSuite_dual_vlan.py
> +++ b/tests/TestSuite_dual_vlan.py
> @@ -364,14 +364,15 @@ class TestDualVlan(TestCase):
>           self.verify(self.nic not in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "hartwell"], "%s NIC not support tcpid " % self.nic)
>   
>           self.mode_config(filter="on", strip="on", qinq="on")
> -        self.dut.send_expect("vlan set tpid 1234 %s" % dutRxPortId, "testpmd> ")
> +        # nic only support inner model, except fortville nic
> +        self.dut.send_expect("vlan set inner tpid 1234 %s" % dutRxPortId, "testpmd> ")
>           self.vlan_send_packet(outvlan, invlan)
>   
>           out = self.get_tcpdump_package()
>           self.verify("vlan %s" % outvlan in out, "vlan tpid disable error: " + out)
>           self.verify("vlan %s" % invlan in out, "vlan tpid disable error: " + out)
>   
> -        self.dut.send_expect("vlan set tpid 0x8100 %s" % dutRxPortId, "testpmd> ")
> +        self.dut.send_expect("vlan set inner tpid 0x8100 %s" % dutRxPortId, "testpmd> ")
>           self.vlan_send_packet(outvlan, invlan)
>   
>           out = self.get_tcpdump_package()