From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 49DB32B99
 for <dts@dpdk.org>; Wed, 29 Jun 2016 02:58:42 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 28 Jun 2016 17:58:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,543,1459839600"; d="scan'208";a="985247367"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by orsmga001.jf.intel.com with ESMTP; 28 Jun 2016 17:58:41 -0700
Message-ID: <57731E04.9080104@intel.com>
Date: Wed, 29 Jun 2016 09:01:56 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Rami Rosen <rami.rosen@intel.com>
CC: dts@dpdk.org
References: <1466963902-23114-1-git-send-email-rami.rosen@intel.com>
In-Reply-To: <1466963902-23114-1-git-send-email-rami.rosen@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH] framework: avoid error on import pxssh.
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2016 00:58:43 -0000

Thanks Rami, applied.

On 06/27/2016 01:58 AM, Rami Rosen wrote:
> This patch adds "from pexpect" to the "import pxsh" call. In newer versions
> (higher than 4) of python-pexpect, not having "from expect" will cause the
> following error: "ImportError: No module named pxssh".
> See also: https://github.com/pexpect/pexpect/issues/302
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>   framework/ssh_pexpect.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py
> index 96c4409..f0348b6 100644
> --- a/framework/ssh_pexpect.py
> +++ b/framework/ssh_pexpect.py
> @@ -1,6 +1,6 @@
>   import time
>   import pexpect
> -import pxssh
> +from pexpect import pxssh
>   from debugger import ignore_keyintr, aware_keyintr
>   from exception import TimeoutException, SSHConnectionException, SSHSessionDeadException
>   from utils import RED, GREEN