From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 4706DDE3
 for <dts@dpdk.org>; Tue, 12 Jul 2016 03:12:21 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga101.jf.intel.com with ESMTP; 11 Jul 2016 18:12:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,349,1464678000"; d="scan'208";a="137548882"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by fmsmga004.fm.intel.com with ESMTP; 11 Jul 2016 18:12:19 -0700
Message-ID: <578444BD.5050103@intel.com>
Date: Tue, 12 Jul 2016 09:15:41 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Lijuan Tu <lijuanx.a.tu@intel.com>, dts@dpdk.org
References: <1468201748-42995-1-git-send-email-lijuanx.a.tu@intel.com>
In-Reply-To: <1468201748-42995-1-git-send-email-lijuanx.a.tu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH]tests vf_to_vf_nic_bridge:fix "killall tcpdump"
 won't get usefull infomation
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jul 2016 01:12:21 -0000

Applied, fixed some typo in git commit.

On 07/11/2016 09:49 AM, Lijuan Tu wrote:
> we use "killall tcpdump" to get "x packets captured" infomation before.
> but on some os ,it is invalid.
>
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>   tests/TestSuite_vf_to_vf_nic_bridge.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_vf_to_vf_nic_bridge.py b/tests/TestSuite_vf_to_vf_nic_bridge.py
> index 4137404..9c5548b 100644
> --- a/tests/TestSuite_vf_to_vf_nic_bridge.py
> +++ b/tests/TestSuite_vf_to_vf_nic_bridge.py
> @@ -187,7 +187,7 @@ class TestVF2VFBridge(TestCase):
>           self.vm0_dut.restore_interfaces()
>           self.vm0_ports = self.vm0_dut.get_ports('any')
>           vf0_intf = self.vm0_dut.ports_info[self.vm0_ports[0]]['intf']
> -        self.vm0_dut.send_expect('tcpdump -i %s -s 1000 > /dev/null &' % vf0_intf, '#', 30)
> +        self.vm0_dut.send_expect('tcpdump -i %s -s 1000 ' % vf0_intf, 'tcpdump', 30)
>   
>           self.vm1_ports = self.vm1_dut.get_ports('any')
>           self.prepare_pktgen(self.vm1_dut)
> @@ -204,7 +204,7 @@ class TestVF2VFBridge(TestCase):
>           self.send_stream_pktgen(self.vm1_dut)
>           self.stop_stream_pktgen(self.vm1_dut)
>   
> -        recv_tcpdump = self.vm0_dut.send_expect('killall tcpdump', '#', 30)
> +        recv_tcpdump = self.vm0_dut.send_expect('^C', '#', 30)
>           time.sleep(5)
>           recv_pattern = re.compile("(\d+) packets captured")
>           recv_info = recv_pattern.search(recv_tcpdump)