* [dts] [PATCH]tests vf_to_vf_nic_bridge:fix "killall tcpdump" won't get usefull infomation
@ 2016-07-11 1:49 Lijuan Tu
2016-07-12 1:15 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: Lijuan Tu @ 2016-07-11 1:49 UTC (permalink / raw)
To: dts; +Cc: Lijuan Tu
we use "killall tcpdump" to get "x packets captured" infomation before.
but on some os ,it is invalid.
Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
tests/TestSuite_vf_to_vf_nic_bridge.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_vf_to_vf_nic_bridge.py b/tests/TestSuite_vf_to_vf_nic_bridge.py
index 4137404..9c5548b 100644
--- a/tests/TestSuite_vf_to_vf_nic_bridge.py
+++ b/tests/TestSuite_vf_to_vf_nic_bridge.py
@@ -187,7 +187,7 @@ class TestVF2VFBridge(TestCase):
self.vm0_dut.restore_interfaces()
self.vm0_ports = self.vm0_dut.get_ports('any')
vf0_intf = self.vm0_dut.ports_info[self.vm0_ports[0]]['intf']
- self.vm0_dut.send_expect('tcpdump -i %s -s 1000 > /dev/null &' % vf0_intf, '#', 30)
+ self.vm0_dut.send_expect('tcpdump -i %s -s 1000 ' % vf0_intf, 'tcpdump', 30)
self.vm1_ports = self.vm1_dut.get_ports('any')
self.prepare_pktgen(self.vm1_dut)
@@ -204,7 +204,7 @@ class TestVF2VFBridge(TestCase):
self.send_stream_pktgen(self.vm1_dut)
self.stop_stream_pktgen(self.vm1_dut)
- recv_tcpdump = self.vm0_dut.send_expect('killall tcpdump', '#', 30)
+ recv_tcpdump = self.vm0_dut.send_expect('^C', '#', 30)
time.sleep(5)
recv_pattern = re.compile("(\d+) packets captured")
recv_info = recv_pattern.search(recv_tcpdump)
--
2.5.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dts] [PATCH]tests vf_to_vf_nic_bridge:fix "killall tcpdump" won't get usefull infomation
2016-07-11 1:49 [dts] [PATCH]tests vf_to_vf_nic_bridge:fix "killall tcpdump" won't get usefull infomation Lijuan Tu
@ 2016-07-12 1:15 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2016-07-12 1:15 UTC (permalink / raw)
To: Lijuan Tu, dts
Applied, fixed some typo in git commit.
On 07/11/2016 09:49 AM, Lijuan Tu wrote:
> we use "killall tcpdump" to get "x packets captured" infomation before.
> but on some os ,it is invalid.
>
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
> tests/TestSuite_vf_to_vf_nic_bridge.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_vf_to_vf_nic_bridge.py b/tests/TestSuite_vf_to_vf_nic_bridge.py
> index 4137404..9c5548b 100644
> --- a/tests/TestSuite_vf_to_vf_nic_bridge.py
> +++ b/tests/TestSuite_vf_to_vf_nic_bridge.py
> @@ -187,7 +187,7 @@ class TestVF2VFBridge(TestCase):
> self.vm0_dut.restore_interfaces()
> self.vm0_ports = self.vm0_dut.get_ports('any')
> vf0_intf = self.vm0_dut.ports_info[self.vm0_ports[0]]['intf']
> - self.vm0_dut.send_expect('tcpdump -i %s -s 1000 > /dev/null &' % vf0_intf, '#', 30)
> + self.vm0_dut.send_expect('tcpdump -i %s -s 1000 ' % vf0_intf, 'tcpdump', 30)
>
> self.vm1_ports = self.vm1_dut.get_ports('any')
> self.prepare_pktgen(self.vm1_dut)
> @@ -204,7 +204,7 @@ class TestVF2VFBridge(TestCase):
> self.send_stream_pktgen(self.vm1_dut)
> self.stop_stream_pktgen(self.vm1_dut)
>
> - recv_tcpdump = self.vm0_dut.send_expect('killall tcpdump', '#', 30)
> + recv_tcpdump = self.vm0_dut.send_expect('^C', '#', 30)
> time.sleep(5)
> recv_pattern = re.compile("(\d+) packets captured")
> recv_info = recv_pattern.search(recv_tcpdump)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-12 1:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-11 1:49 [dts] [PATCH]tests vf_to_vf_nic_bridge:fix "killall tcpdump" won't get usefull infomation Lijuan Tu
2016-07-12 1:15 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).