test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Lijuan Tu <lijuanx.a.tu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1 2/2] add unit_tests_distributor test script
Date: Wed, 03 Aug 2016 09:47:22 +0800	[thread overview]
Message-ID: <57A14D2A.5020300@intel.com> (raw)
In-Reply-To: <1470027062-7342-1-git-send-email-lijuanx.a.tu@intel.com>

Lijuan, some comments below.

On 08/01/2016 12:51 PM, Lijuan Tu wrote:
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>   tests/TestSuite_unit_tests_distributor.py | 129 ++++++++++++++++++++++++++++++
>   1 file changed, 129 insertions(+)
>   create mode 100644 tests/TestSuite_unit_tests_distributor.py
>
> diff --git a/tests/TestSuite_unit_tests_distributor.py b/tests/TestSuite_unit_tests_distributor.py
> new file mode 100644
> index 0000000..55f5a80
> --- /dev/null
> +++ b/tests/TestSuite_unit_tests_distributor.py
> @@ -0,0 +1,129 @@
> +# BSD LICENSE
> +#
> +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> +# All rights reserved.

Copyright should update.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +#
> +#   * Redistributions of source code must retain the above copyright
> +#     notice, this list of conditions and the following disclaimer.
> +#   * Redistributions in binary form must reproduce the above copyright
> +#     notice, this list of conditions and the following disclaimer in
> +#     the documentation and/or other materials provided with the
> +#     distribution.
> +#   * Neither the name of Intel Corporation nor the names of its
> +#     contributors may be used to endorse or promote products derived
> +#     from this software without specific prior written permission.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +"""
> +DPDK Test suite.
> +
> +This TestSuite runs the unit tests included in DPDK for power feature.
> +"""
> +
> +from test_case import TestCase
> +
> +#
> +#
> +# Test class.
> +#
> +
> +
> +class TestUnitTestsDistributor(TestCase):
> +
> +    #
> +    #
> +    #
> +    # Test cases.
> +    #
> +
> +    def set_up_all(self):
> +        """
> +        Run at the start of each test suite.
> +
> +        Power Prerequisites

Since this suite required lot of lcores, need check in set_up_all function.
> +        """
> +        out = self.dut.build_dpdk_apps('./app/test/')
> +        self.verify('make: Leaving directory' in out, "Compilation failed")
> +
> +    def set_up(self):
> +        """
> +        Run before each test case.
> +        """
> +        pass
> +
> +    def test_1_distributor_1_worker(self):
> +        """
> +        Run power autotest.
Test case description tope.
> +        """
> +
Core should be gotten by dut.get_core_list() function and mask generate 
by create_mask function.
Please add description in test plan, couldn't know the difference 
between each case.
> +        self.dut.send_expect("./app/test/test -n 4 -c 0xC", "R.*T.*E.*>.*>", 60)
> +        out = self.dut.send_expect("distributor_autotest", "RTE>>", 60)
> +        self.dut.send_expect("quit", "# ")
> +        self.verify("Test OK" in out, "Test failed")
> +
> +    def test_1_distributor_4_worker(self):
> +        """
> +        Run power autotest.
> +        """
> +
> +        self.dut.send_expect("./app/test/test -n 4 -c 0x3E", "R.*T.*E.*>.*>", 60)
> +        out = self.dut.send_expect("distributor_autotest", "RTE>>", 60)
> +        self.dut.send_expect("quit", "# ")
> +        self.verify("Test OK" in out, "Test failed")
> +
> +    def test_1_distributor_8_worker(self):
> +        """
> +        Run power autotest.
> +        """
> +
> +        self.dut.send_expect("./app/test/test -n 4 -c 0x3FE", "R.*T.*E.*>.*>", 60)
> +        out = self.dut.send_expect("distributor_autotest", "RTE>>", 60)
> +        self.dut.send_expect("quit", "# ")
> +        self.verify("Test OK" in out, "Test failed")
> +
> +    def test_1_distributor_10_worker(self):
> +        """
> +        Run power autotest.
> +        """
> +
> +        self.dut.send_expect("./app/test/test -n 4 -c 0xFFE", "R.*T.*E.*>.*>", 60)
> +        out = self.dut.send_expect("distributor_autotest", "RTE>>", 60)
> +        self.dut.send_expect("quit", "# ")
> +        self.verify("Test OK" in out, "Test failed")
> +
> +    def test_1_distributor_5_worker(self):
> +        """
> +        Run power autotest.
> +        """
> +
> +        self.dut.send_expect("./app/test/test -n 4 -c 0x100F", "R.*T.*E.*>.*>", 60)
> +        out = self.dut.send_expect("distributor_autotest", "RTE>>", 60)
> +        self.dut.send_expect("quit", "# ")
> +        self.verify("Test OK" in out, "Test failed")
> +
> +    def tear_down(self):
> +        """
> +        Run after each test case.
> +        """
> +        pass
> +
> +    def tear_down_all(self):
> +        """
> +        Run after each test suite.
> +        """
> +        pass

      reply	other threads:[~2016-08-03  1:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01  4:41 [dts] [PATCH V1 0/2] Add packet distributor unit test plan and " Lijuan Tu
2016-08-01  4:49 ` [dts] [PATCH V1 1/2] add unit_tests_distributor_test_plan Lijuan Tu
2016-08-03  1:36   ` Liu, Yong
2016-08-01  4:51 ` [dts] [PATCH V1 2/2] add unit_tests_distributor test script Lijuan Tu
2016-08-03  1:47   ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57A14D2A.5020300@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuanx.a.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).