test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Lijuan Tu <lijuanx.a.tu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [next]virt: fix attribute and argument error
Date: Wed, 10 Aug 2016 10:12:56 +0800	[thread overview]
Message-ID: <57AA8DA8.9040709@intel.com> (raw)
In-Reply-To: <1470728589-5075-1-git-send-email-lijuanx.a.tu@intel.com>

Thanks, applied into next branch.

On 08/09/2016 03:43 PM, Lijuan Tu wrote:
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>   framework/virt_base.py | 7 ++++---
>   framework/virt_dut.py  | 2 +-
>   2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/framework/virt_base.py b/framework/virt_base.py
> index e6a6d08..78e3334 100644
> --- a/framework/virt_base.py
> +++ b/framework/virt_base.py
> @@ -364,9 +364,10 @@ class VirtBase(object):
>           skip_setup = self.host_dut.skip_setup
>           base_dir = self.host_dut.base_dir
>           vm_dut.set_speedup_options(read_cache, skip_setup)
> -        func_only = self.host_dut.want_func_tests
> -        perf_only = self.host_dut.want_perf_tests
> -        vm_dut.set_test_types(func_tests=func_only, perf_tests=perf_only)
> +
> +        # package and patch should be set before prerequisites
> +        vm_dut.set_package(self.host_dut.package, self.host_dut.patches)
> +
>           # base_dir should be set before prerequisites
>           vm_dut.set_directory(base_dir)
>   
> diff --git a/framework/virt_dut.py b/framework/virt_dut.py
> index e13c48c..348279d 100644
> --- a/framework/virt_dut.py
> +++ b/framework/virt_dut.py
> @@ -150,7 +150,7 @@ class VirtDut(DPDKdut):
>           At last setup DUT' environment for validation.
>           """
>           if not self.skip_setup:
> -            self.prepare_package(pkgName, patch)
> +            self.prepare_package()
>   
>           self.send_expect("cd %s" % self.base_dir, "# ")
>           self.send_expect("alias ls='ls --color=none'", "#")

      reply	other threads:[~2016-08-10  2:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09  7:43 Lijuan Tu
2016-08-10  2:12 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57AA8DA8.9040709@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuanx.a.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).