From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 8B1BE5599
 for <dts@dpdk.org>; Wed, 10 Aug 2016 04:09:49 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga102.fm.intel.com with ESMTP; 09 Aug 2016 19:09:48 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,497,1464678000"; d="scan'208";a="1032844185"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by orsmga002.jf.intel.com with ESMTP; 09 Aug 2016 19:09:47 -0700
Message-ID: <57AA8DA8.9040709@intel.com>
Date: Wed, 10 Aug 2016 10:12:56 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Lijuan Tu <lijuanx.a.tu@intel.com>, dts@dpdk.org
References: <1470728589-5075-1-git-send-email-lijuanx.a.tu@intel.com>
In-Reply-To: <1470728589-5075-1-git-send-email-lijuanx.a.tu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [next]virt: fix attribute and argument error
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Aug 2016 02:09:49 -0000

Thanks, applied into next branch.

On 08/09/2016 03:43 PM, Lijuan Tu wrote:
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>   framework/virt_base.py | 7 ++++---
>   framework/virt_dut.py  | 2 +-
>   2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/framework/virt_base.py b/framework/virt_base.py
> index e6a6d08..78e3334 100644
> --- a/framework/virt_base.py
> +++ b/framework/virt_base.py
> @@ -364,9 +364,10 @@ class VirtBase(object):
>           skip_setup = self.host_dut.skip_setup
>           base_dir = self.host_dut.base_dir
>           vm_dut.set_speedup_options(read_cache, skip_setup)
> -        func_only = self.host_dut.want_func_tests
> -        perf_only = self.host_dut.want_perf_tests
> -        vm_dut.set_test_types(func_tests=func_only, perf_tests=perf_only)
> +
> +        # package and patch should be set before prerequisites
> +        vm_dut.set_package(self.host_dut.package, self.host_dut.patches)
> +
>           # base_dir should be set before prerequisites
>           vm_dut.set_directory(base_dir)
>   
> diff --git a/framework/virt_dut.py b/framework/virt_dut.py
> index e13c48c..348279d 100644
> --- a/framework/virt_dut.py
> +++ b/framework/virt_dut.py
> @@ -150,7 +150,7 @@ class VirtDut(DPDKdut):
>           At last setup DUT' environment for validation.
>           """
>           if not self.skip_setup:
> -            self.prepare_package(pkgName, patch)
> +            self.prepare_package()
>   
>           self.send_expect("cd %s" % self.base_dir, "# ")
>           self.send_expect("alias ls='ls --color=none'", "#")