From: "Liu, Yong" <yong.liu@intel.com>
To: "xueqin.lin" <xlin15@ecsmtp.sh.intel.com>, dts@dpdk.org
Cc: Xueqin Lin <xueqin.lin@intel.com>
Subject: Re: [dts] [PATCH]add configuration detection for RSS hash at ethernet port
Date: Fri, 12 Aug 2016 13:40:53 +0800 [thread overview]
Message-ID: <57AD6165.6040605@intel.com> (raw)
In-Reply-To: <1470909041-25668-1-git-send-email-xlin15@shecgisg005.sh.intel.com>
Thanks, applied.
On 08/11/2016 05:50 PM, xueqin.lin wrote:
> From: Xueqin Lin <xueqin.lin@intel.com>
>
> Code can not capture configuration error of RSS hash at ethernet port, add this verification.
>
> ---
> tests/TestSuite_pmdrss_hash.py | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
> index 0cb703b..ebba3e7 100644
> --- a/tests/TestSuite_pmdrss_hash.py
> +++ b/tests/TestSuite_pmdrss_hash.py
> @@ -475,9 +475,9 @@ class TestPmdrssHash(TestCase):
> self.dut.send_expect(
> "set_hash_global_config 0 toeplitz %s enable" % iptype, "testpmd> ")
> self.dut.send_expect("port start all", "testpmd> ")
> - self.dut.send_expect(
> + out = self.dut.send_expect(
> "port config all rss %s" % rsstype, "testpmd> ")
> -
> + self.verify("error" not in out, "Configuration of RSS hash failed: Invalid argument")
> # configure the reta with specific mappings.
> for i in range(reta_num):
> reta_entries.insert(i, random.randint(0, queue - 1))
> @@ -527,8 +527,9 @@ class TestPmdrssHash(TestCase):
> self.dut.send_expect(
> "set_sym_hash_ena_per_port 0 enable", "testpmd> ")
> self.dut.send_expect("port start all", "testpmd> ")
> - self.dut.send_expect(
> + out = self.dut.send_expect(
> "port config all rss %s" % rsstype, "testpmd> ")
> + self.verify("error" not in out, "Configuration of RSS hash failed: Invalid argument")
>
> # configure the reta with specific mappings.
> for i in range(reta_num):
> @@ -580,9 +581,9 @@ class TestPmdrssHash(TestCase):
> self.dut.send_expect(
> "set_hash_global_config 0 simple_xor %s enable" % iptype, "testpmd> ")
> self.dut.send_expect("port start all", "testpmd> ")
> - self.dut.send_expect(
> + out = self.dut.send_expect(
> "port config all rss %s" % rsstype, "testpmd> ")
> -
> + self.verify("error" not in out, "Configuration of RSS hash failed: Invalid argument")
> # configure the reta with specific mappings.
> for i in range(reta_num):
> reta_entries.insert(i, random.randint(0, queue - 1))
> @@ -633,8 +634,10 @@ class TestPmdrssHash(TestCase):
> self.dut.send_expect(
> "set_sym_hash_ena_per_port 0 enable", "testpmd> ")
> self.dut.send_expect("port start all", "testpmd> ")
> - self.dut.send_expect(
> +
> + out = self.dut.send_expect(
> "port config all rss %s" % rsstype, "testpmd> ")
> + self.verify("error" not in out, "Configuration of RSS hash failed: Invalid argument")
> # configure the reta with specific mappings.
> for i in range(reta_num):
> reta_entries.insert(i, random.randint(0, queue - 1))
parent reply other threads:[~2016-08-12 5:37 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1470909041-25668-1-git-send-email-xlin15@shecgisg005.sh.intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57AD6165.6040605@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=xlin15@ecsmtp.sh.intel.com \
--cc=xueqin.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).