From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 004B458F7 for ; Fri, 12 Aug 2016 07:37:55 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 11 Aug 2016 22:37:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,508,1464678000"; d="scan'208";a="1039821261" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by fmsmga002.fm.intel.com with ESMTP; 11 Aug 2016 22:37:54 -0700 Message-ID: <57AD6165.6040605@intel.com> Date: Fri, 12 Aug 2016 13:40:53 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "xueqin.lin" , dts@dpdk.org CC: Xueqin Lin References: <1470909041-25668-1-git-send-email-xlin15@shecgisg005.sh.intel.com> In-Reply-To: <1470909041-25668-1-git-send-email-xlin15@shecgisg005.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH]add configuration detection for RSS hash at ethernet port X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 05:37:56 -0000 Thanks, applied. On 08/11/2016 05:50 PM, xueqin.lin wrote: > From: Xueqin Lin > > Code can not capture configuration error of RSS hash at ethernet port, add this verification. > > --- > tests/TestSuite_pmdrss_hash.py | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py > index 0cb703b..ebba3e7 100644 > --- a/tests/TestSuite_pmdrss_hash.py > +++ b/tests/TestSuite_pmdrss_hash.py > @@ -475,9 +475,9 @@ class TestPmdrssHash(TestCase): > self.dut.send_expect( > "set_hash_global_config 0 toeplitz %s enable" % iptype, "testpmd> ") > self.dut.send_expect("port start all", "testpmd> ") > - self.dut.send_expect( > + out = self.dut.send_expect( > "port config all rss %s" % rsstype, "testpmd> ") > - > + self.verify("error" not in out, "Configuration of RSS hash failed: Invalid argument") > # configure the reta with specific mappings. > for i in range(reta_num): > reta_entries.insert(i, random.randint(0, queue - 1)) > @@ -527,8 +527,9 @@ class TestPmdrssHash(TestCase): > self.dut.send_expect( > "set_sym_hash_ena_per_port 0 enable", "testpmd> ") > self.dut.send_expect("port start all", "testpmd> ") > - self.dut.send_expect( > + out = self.dut.send_expect( > "port config all rss %s" % rsstype, "testpmd> ") > + self.verify("error" not in out, "Configuration of RSS hash failed: Invalid argument") > > # configure the reta with specific mappings. > for i in range(reta_num): > @@ -580,9 +581,9 @@ class TestPmdrssHash(TestCase): > self.dut.send_expect( > "set_hash_global_config 0 simple_xor %s enable" % iptype, "testpmd> ") > self.dut.send_expect("port start all", "testpmd> ") > - self.dut.send_expect( > + out = self.dut.send_expect( > "port config all rss %s" % rsstype, "testpmd> ") > - > + self.verify("error" not in out, "Configuration of RSS hash failed: Invalid argument") > # configure the reta with specific mappings. > for i in range(reta_num): > reta_entries.insert(i, random.randint(0, queue - 1)) > @@ -633,8 +634,10 @@ class TestPmdrssHash(TestCase): > self.dut.send_expect( > "set_sym_hash_ena_per_port 0 enable", "testpmd> ") > self.dut.send_expect("port start all", "testpmd> ") > - self.dut.send_expect( > + > + out = self.dut.send_expect( > "port config all rss %s" % rsstype, "testpmd> ") > + self.verify("error" not in out, "Configuration of RSS hash failed: Invalid argument") > # configure the reta with specific mappings. > for i in range(reta_num): > reta_entries.insert(i, random.randint(0, queue - 1))