Re: [dts] [PATCH V1] update ringpmd test case

["Liu, Yong" <yong.liu@intel.com>]

Thanks, applied with comments modified.

On 08/19/2016 02:11 PM, xu,huilong wrote:
> update list:
> 1. remove attach and dettach module, the test function not support already
> 2. remove port work model module, the test function not support already
> 3. support default ring_pmd in test case
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_unit_tests_ringpmd.py | 19 ++++++++-----------
>   1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_ringpmd.py b/tests/TestSuite_unit_tests_ringpmd.py
> index 39d85b0..2c83bcd 100644
> --- a/tests/TestSuite_unit_tests_ringpmd.py
> +++ b/tests/TestSuite_unit_tests_ringpmd.py
> @@ -57,10 +57,7 @@ class TestUnitTestsRingPmd(TestCase):
>           Run at the start of each test suite.
>           Nothing to do here.
>           """
> -        self.ring_ports = [{'mode': 'tx', 'index': '0'},
> -                           {'mode': 'rxtx', 'index': '1'},
> -                           {'mode': 'tx', 'index': '2'}]
> -
> +        pass
>       def set_up(self):
>           """
>           Run before each test case.
> @@ -72,17 +69,17 @@ class TestUnitTestsRingPmd(TestCase):
>           """
>           Run Inter-VM share memory test.
>           """
> -        dev_str = ""
> -        for port in self.ring_ports:
> -            if port['mode'] == 'tx':
> -                dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index']
> -            else:
> -                dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index']
> +        dev_str = "--vdev=eth_ring0 --vdev=eth_ring1"
> +
> +        self.dut.send_expect("./%s/app/test -n 1 -c ffff" % self.target, "R.*T.*E.*>.*>", 10)
> +        out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
> +        self.dut.send_expect("quit", "# ")
> +        self.verify("Test OK" in out, "Default no eth_ring devices Test failed")
>   
>           self.dut.send_expect("./%s/app/test -n 1 -c ffff %s" % (self.target, dev_str), "R.*T.*E.*>.*>", 10)
>           out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
>           self.dut.send_expect("quit", "# ")
> -        self.verify("Test OK" in out, "Test failed")
> +        self.verify("Test OK" in out, "Two eth_ring devices test failed")
>   
>       def tear_down(self):
>           """