From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 2E76769FE
 for <dts@dpdk.org>; Fri, 19 Aug 2016 08:56:57 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga103.jf.intel.com with ESMTP; 18 Aug 2016 23:56:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,544,1464678000"; d="scan'208";a="158247208"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by fmsmga004.fm.intel.com with ESMTP; 18 Aug 2016 23:56:55 -0700
Message-ID: <57B6AE4E.8020401@intel.com>
Date: Fri, 19 Aug 2016 14:59:26 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
References: <1471587106-19963-1-git-send-email-huilongx.xu@intel.com>
In-Reply-To: <1471587106-19963-1-git-send-email-huilongx.xu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH V1] update ringpmd test case
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Aug 2016 06:56:57 -0000

Thanks, applied with comments modified.

On 08/19/2016 02:11 PM, xu,huilong wrote:
> update list:
> 1. remove attach and dettach module, the test function not support already
> 2. remove port work model module, the test function not support already
> 3. support default ring_pmd in test case
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_unit_tests_ringpmd.py | 19 ++++++++-----------
>   1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_ringpmd.py b/tests/TestSuite_unit_tests_ringpmd.py
> index 39d85b0..2c83bcd 100644
> --- a/tests/TestSuite_unit_tests_ringpmd.py
> +++ b/tests/TestSuite_unit_tests_ringpmd.py
> @@ -57,10 +57,7 @@ class TestUnitTestsRingPmd(TestCase):
>           Run at the start of each test suite.
>           Nothing to do here.
>           """
> -        self.ring_ports = [{'mode': 'tx', 'index': '0'},
> -                           {'mode': 'rxtx', 'index': '1'},
> -                           {'mode': 'tx', 'index': '2'}]
> -
> +        pass
>       def set_up(self):
>           """
>           Run before each test case.
> @@ -72,17 +69,17 @@ class TestUnitTestsRingPmd(TestCase):
>           """
>           Run Inter-VM share memory test.
>           """
> -        dev_str = ""
> -        for port in self.ring_ports:
> -            if port['mode'] == 'tx':
> -                dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index']
> -            else:
> -                dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index']
> +        dev_str = "--vdev=eth_ring0 --vdev=eth_ring1"
> +
> +        self.dut.send_expect("./%s/app/test -n 1 -c ffff" % self.target, "R.*T.*E.*>.*>", 10)
> +        out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
> +        self.dut.send_expect("quit", "# ")
> +        self.verify("Test OK" in out, "Default no eth_ring devices Test failed")
>   
>           self.dut.send_expect("./%s/app/test -n 1 -c ffff %s" % (self.target, dev_str), "R.*T.*E.*>.*>", 10)
>           out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
>           self.dut.send_expect("quit", "# ")
> -        self.verify("Test OK" in out, "Test failed")
> +        self.verify("Test OK" in out, "Two eth_ring devices test failed")
>   
>       def tear_down(self):
>           """