test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1 1/2] add ip_pipeline source_sink test code
Date: Thu, 25 Aug 2016 10:36:37 +0800	[thread overview]
Message-ID: <57BE59B5.90706@intel.com> (raw)
In-Reply-To: <1471944392-26112-11-git-send-email-gangx.xu@intel.com>

Thanks, gang. Few comments.

On 08/23/2016 05:26 PM, xu,gang wrote:
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   tests/TestSuite_ip_pipeline_source_sink.py | 194 +++++++++++++++++++++++++++++
>   1 file changed, 194 insertions(+)
>   create mode 100644 tests/TestSuite_ip_pipeline_source_sink.py
>
> diff --git a/tests/TestSuite_ip_pipeline_source_sink.py b/tests/TestSuite_ip_pipeline_source_sink.py
> new file mode 100644
> index 0000000..f60c75c
> --- /dev/null
> +++ b/tests/TestSuite_ip_pipeline_source_sink.py
> @@ -0,0 +1,194 @@
> +#BSD LICENSE
> +#
> +# Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> +# All rights reserved.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +#
> +#   * Redistributions of source code must retain the above copyright
> +#     notice, this list of conditions and the following disclaimer.
> +#   * Redistributions in binary form must reproduce the above copyright
> +#     notice, this list of conditions and the following disclaimer in
> +#     the documentation and/or other materials provided with the
> +#     distribution.
> +#   * Neither the name of Intel Corporation nor the names of its
> +#     contributors may be used to endorse or promote products derived
> +#     from this software without specific prior written permission.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +
> +"""
> +DPDK Test suite.
> +Test ip_pipeline_source_sink.
> +"""
> +
> +import dts
> +import string
> +import time
> +import re
> +import os
> +from test_case import TestCase
> +from plotting import Plotting
> +from settings import HEADER_SIZE
> +from etgen import IxiaPacketGenerator
> +from packet import Packet, sniff_packets, load_sniff_packets
> +
> +class Test_ip_pipeline_source_sink(TestCase):
> +
> +    def set_up_all(self):
> +        """
> +        Run at the start of each test suite.
> +        """
> +        self.dut_ports = self.dut.get_ports(self.nic)
> +        self.verify(len(self.dut_ports) >= 2, "Insufficient ports")
> +        cores = self.dut.get_core_list("1S/4C/1T")
> +        self.coremask = dts.create_mask(cores)
> +
> +        self.path = "./examples/ip_pipeline/build/ip_pipeline"
> +
> +        put = self.dut.send_expect("sed -n '510,520p' config/common_base","Compile librte_table",30)
> +        self.verify("CONFIG_RTE_PORT_PCAP=y" in put, "CONFIG_RTE_PORT_PCAP=n")
> +
Line number may changed in different version, no need to user line number.

> +        self.dut.session.copy_file_to("dep/ip_pipeline.tar.gz -C ~")
> +        self.dut.send_expect("tar -zxvf ~/ip_pipeline.tar.gz","#",50)
> +
> +        # build sample app
> +        out = self.dut.build_dpdk_apps("./examples/ip_pipeline")
> +        self.verify("Error" not in out, "compilation error 1")
> +        self.verify("No such file" not in out, "compilation error 2")
> +        self.dut.send_expect("cp -a -f ~/ip_pipeline/eth1.1.pcap ~/ip_pipeline/eth1.pcap ~/ip_pipeline/eth2.1.pcap \
> +                             ~/ip_pipeline/eth2.pcap ~/ip_pipeline/eth3.1.pacp ~/ip_pipeline/eth3.pcap \
> +                             ~/ip_pipeline/eth4.1.pcap ~/ip_pipeline/eth4.pcap ~","# ",50)
Suggest to use list for so many pcap files.

> +
> +    def set_up(self):
> +        """
> +        Run before each test case.
> +        """
> +        pass
> +
> +    def test_postive(self):
> +        rootdir = "dep/ip_pipeline/ip_pipeline_source_sink/postive/"
> +        for parent,dirnames,filenames in os.walk(rootdir):
> +            for filename in filenames:
> +                cmd = self.path + " -f ~/ip_pipeline/ip_pipeline_source_sink/postive/%s" % filename
> +                self.dut.send_expect(cmd,"[PIPELINE1]",50)
> +                out = self.dut.send_expect("quit","# ",10)
> +                self.verify("Bye!" in out, "Test failed on %s" % filename)
> +
> +    def test_negative(self):
> +        rootdir = "dep/ip_pipeline/ip_pipeline_source_sink/negative/"
> +        for parent,dirnames,filenames in os.walk(rootdir):
> +            for filename in filenames:
> +                cmd = self.path + " -f ~/ip_pipeline/ip_pipeline_source_sink/negative/%s" % filename
> +                out = self.dut.send_expect(cmd,"# ",50)
> +                self.verify("error" in out, "Test failed on %s" % filename)
> +
> +
> +
> +    def check_pacp_frame(self,pcapfile):
> +        self.dut.send_expect("scapy","Welcome to Scapy",50)
> +        self.dut.send_expect("p=rdpcap('%s')"% pcapfile,">>> ",500)
> +        out = self.dut.send_expect("p",">>> ",50)
> +        self.dut.send_expect("quit()","#",50)
> +        list1 = out.split()
> +        list2 = list1[1].split(":")
> +        return list2[1]
> +
> +    def test_source_sink_3(self):
> +
> +        cmd = self.path + " -f ~/ip_pipeline/ip_pipeline_source_sink/source_sink_3.cfg"
> +        out1=self.dut.send_expect(cmd,"[PIPELINE1]",50)
> +        time.sleep(10)
> +        out = self.dut.send_expect("quit","# ",10)
> +        eth1_1 = self.check_pacp_frame("/root/eth1.1.pcap")
> +        eth2_1 = self.check_pacp_frame("/root/eth2.1.pcap")
> +        self.verify("80" in eth1_1 and "200" in eth2_1, "test FAILED")
> +
> +
> +    def test_source_sink_4(self):
> +        cmd = self.path + " -f ~/ip_pipeline/ip_pipeline_source_sink/source_sink_4.cfg"
> +        self.dut.send_expect(cmd,"[PIPELINE1]",50)
> +        time.sleep(10)
> +        out = self.dut.send_expect("quit","# ",10)
> +        eth1_1 = self.check_pacp_frame("/root/eth1.1.pcap")
> +        eth2_1 = self.check_pacp_frame("/root/eth2.1.pcap")
> +        self.verify("80" in eth1_1 and "80" in eth1_1, "test FAILED")
> +
> +    def test_source_sink_5(self):
> +        cmd = self.path + " -f ~/ip_pipeline/ip_pipeline_source_sink/source_sink_5.cfg"
> +        self.dut.send_expect(cmd,"[PIPELINE1]",50)
> +        time.sleep(10)
> +        out = self.dut.send_expect("quit","# ",10)
> +        eth1_1 = self.check_pacp_frame("/root/eth1.1.pcap")
> +        self.verify("200" in eth1_1, "test FAILED")
> +
> +    def test_source_sink_7(self):
> +        cmd = self.path + " -f ~/ip_pipeline/ip_pipeline_source_sink/source_sink_7.cfg"
> +        self.dut.send_expect(cmd,"[PIPELINE1]",50)
> +        time.sleep(10)
> +        out = self.dut.send_expect("quit","# ",10)
> +        eth1_1 = self.check_pacp_frame("/root/eth1.1.pcap")
> +        eth2_1 = self.check_pacp_frame("/root/eth2.1.pcap")
> +        eth3_1 = self.check_pacp_frame("/root/eth3.1.pcap")
> +        eth4_1 = self.check_pacp_frame("/root/eth4.1.pcap")
> +
> +        self.verify("80" in eth1_1 and "200" in eth2_1 and "80" in eth3_1 and "200" in eth4_1, "test FAILED")
> +
> +    def test_source_sink_8(self):
> +        cmd = self.path + " -f ~/ip_pipeline/ip_pipeline_source_sink/source_sink_8.cfg"
> +        self.dut.send_expect(cmd,"[PIPELINE1]",50)
> +        time.sleep(10)
> +        out = self.dut.send_expect("quit","# ",10)
> +        eth1_1 = self.check_pacp_frame("/root/eth1.1.pcap")
> +        eth2_1 = self.check_pacp_frame("/root/eth2.1.pcap")
> +        eth3_1 = self.check_pacp_frame("/root/eth3.1.pcap")
> +        eth4_1 = self.check_pacp_frame("/root/eth4.1.pcap")
> +
> +        self.verify("80" in eth1_1 and "200" in eth2_1 and "80" in eth3_1 and "200" in eth4_1, "test FAILED")
> +
> +
> +    def test_source_sink_19(self):
> +        cmd = self.path + " -f ~/ip_pipeline/ip_pipeline_source_sink/source_sink_19.cfg"
> +        self.dut.send_expect(cmd,"[PIPELINE1]",50)
> +        time.sleep(10)
> +        out = self.dut.send_expect("quit","# ",100)
> +        eth1_1 = self.check_pacp_frame("/root/eth1.1.pcap")
> +        self.verify("80" in eth1_1 , "test FAILED")
> +
> +    def test_source_sink_6(self):
> +        cmd = self.path + " -f ~/ip_pipeline/ip_pipeline_source_sink/source_sink_6.cfg"
> +        self.dut.send_expect(cmd,"[PIPELINE1]",100)
> +        time.sleep(30)
> +        out = self.dut.send_expect("quit","# ",600)
> +        eth1_1 = self.check_pacp_frame("/root/eth1.1.pcap")
> +        eth2_1 = self.check_pacp_frame("/root/eth2.1.pcap")
> +        self.verify("80" in eth1_1 and "200" in eth2_1, "test FAILED")
> +
> +
> +    def tear_down(self):
> +        """
> +        Run after each test case.
> +        """
> +        self.dut.send_expect("rm -rf ~/eth1.1.pcap ~/eth1.pcap ~/eth2.1.pcap ~/eth2.pcap ~/eth3.1.pacp ~/eth3.pcap ~/eth4.1.pcap ~/eth4.pcap","# ",50)
> +        self.dut.send_expect("cp -a -f ~/ip_pipeline/eth1.1.pcap ~/ip_pipeline/eth1.pcap ~/ip_pipeline/eth2.1.pcap ~/ip_pipeline/eth2.pcap ~/ip_pipeline/eth3.1.pacp ~/ip_pipeline/eth3.pcap ~/ip_pipeline/eth4.1.pcap ~/ip_pipeline/eth4.pcap ~","# ",50)
Suggest to use list for so many pcap files.

> +        self.dut.kill_all()
> +        time.sleep(2)
> +
> +    def tear_down_all(self):
> +        """
> +        Run after each test suite.
> +        """
> +        pass

  reply	other threads:[~2016-08-25  2:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  9:26 [dts] [PATCH V1 01/2] add keep alive " xu,gang
2016-08-23  9:26 ` [dts] [PATCH V1 02/2] add keep alive test plan xu,gang
2016-08-23  9:26 ` [dts] [PATCH V1 01/2] add ip_pipeline cfg test code xu,gang
2016-08-23  9:26 ` [dts] [PATCH V1 02/2] add ip_pipeline cfg test plan xu,gang
2016-08-25  5:44   ` Liu, Yong
2016-08-23  9:26 ` [dts] [PATCH V1 01/2] add ip_pipeline_cpu_utilization test code xu,gang
2016-08-23  9:26 ` [dts] [PATCH V1 02/2] add ip_pipeline cpu utilization test plan xu,gang
2016-08-25  5:46   ` Liu, Yong
2016-08-23  9:26 ` [dts] [PATCH V1 01/2] add ip_pipeline link_identification test code xu,gang
2016-08-25  5:50   ` Liu, Yong
2016-08-23  9:26 ` [dts] [PATCH V1 02/2] add ip_pipeline link_identification test plan xu,gang
2016-08-23  9:26 ` [dts] [PATCH V1 01/2] add ip_pipeline parser_cleanup test code xu,gang
2016-08-23  9:26 ` [dts] [PATCH V1 2/2] add ip_pipeline parser_cleanup test plan xu,gang
2016-08-25  2:41   ` Liu, Yong
2016-08-23  9:26 ` [dts] [PATCH V1 1/2] add ip_pipeline source_sink test code xu,gang
2016-08-25  2:36   ` Liu, Yong [this message]
2016-08-23  9:26 ` [dts] [PATCH V1 2/2] add ip_pipeline source_sink test plan xu,gang
2016-08-25  5:38 ` [dts] [PATCH V1 01/2] add keep alive test code Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57BE59B5.90706@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).