From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F0CF458F3 for ; Thu, 25 Aug 2016 07:46:48 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 24 Aug 2016 22:46:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,574,1464678000"; d="scan'208";a="753227561" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by FMSMGA003.fm.intel.com with ESMTP; 24 Aug 2016 22:46:46 -0700 Message-ID: <57BE871E.4050001@intel.com> Date: Thu, 25 Aug 2016 13:50:22 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "xu,gang" , dts@dpdk.org References: <1471944392-26112-1-git-send-email-gangx.xu@intel.com> <1471944392-26112-7-git-send-email-gangx.xu@intel.com> In-Reply-To: <1471944392-26112-7-git-send-email-gangx.xu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V1 01/2] add ip_pipeline link_identification test code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2016 05:46:49 -0000 Gang, this suite seem not match the test plan. And one comment below. On 08/23/2016 05:26 PM, xu,gang wrote: > Signed-off-by: xu,gang > --- > tests/TestSuite_ip_pipeline_link_identification.py | 155 +++++++++++++++++++++ > 1 file changed, 155 insertions(+) > create mode 100644 tests/TestSuite_ip_pipeline_link_identification.py > > diff --git a/tests/TestSuite_ip_pipeline_link_identification.py b/tests/TestSuite_ip_pipeline_link_identification.py > new file mode 100644 > index 0000000..a21ab28 > --- /dev/null > +++ b/tests/TestSuite_ip_pipeline_link_identification.py > @@ -0,0 +1,155 @@ > +#BSD LICENSE > +# > +# Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > +# All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without > +# modification, are permitted provided that the following conditions > +# are met: > +# > +# * Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# * Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in > +# the documentation and/or other materials provided with the > +# distribution. > +# * Neither the name of Intel Corporation nor the names of its > +# contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. > +# > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + > + > +""" > +DPDK Test suite. > +Test ip_pipeline_link_identification. > +""" > + > +import dts > +import string > +import time > +import re > +import os > +from test_case import TestCase > +from plotting import Plotting > +from settings import HEADER_SIZE > +from etgen import IxiaPacketGenerator > +from packet import Packet, sniff_packets, load_sniff_packets > + > +class Test_ip_pipeline_link_identification(TestCase): > + > + def set_up_all(self): > + """ > + Run at the start of each test suite. > + """ > + self.dut_ports = self.dut.get_ports(self.nic) > + self.verify(len(self.dut_ports) >= 2, "Insufficient ports") > + cores = self.dut.get_core_list("1S/4C/1T") > + self.coremask = dts.create_mask(cores) > + > + self.packag_ip_pipeline() > + self.dut.session.copy_file_to("dep/ip_pipeline.tar.gz") > + put = self.dut.send_expect("tar -zxvf ~/ip_pipeline.tar.gz -C ~","#",500) > + self.verify("Error" not in put, "tar fail") > + self.path = "./examples/ip_pipeline/build/ip_pipeline" > + > + # build sample app > + out = self.dut.build_dpdk_apps("./examples/ip_pipeline") > + self.verify("Error" not in out, "compilation error 1") > + self.verify("No such file" not in out, "compilation error 2") > + > + def set_up(self): > + """ > + Run before each test case. > + """ > + pass > + > + def replace_pci(self,filename,old,new): > + try: > + lines = open(filename,'r').readlines() > + flen = len(lines) - 1 > + for i in range(flen): > + if old in lines[i]: > + lines[i] = lines[i].replace(old,new) > + open(filename,'w').writelines(lines) > + except Exception,e: > + print e > + > + def packag_ip_pipeline(self): > + rootdir = "dep/ip_pipeline/ip_pipeline_link_identification/postive/" > + for parent,dirnames,filenames in os.walk(rootdir): > + for filename in filenames: > + self.replace_pci(parent + filename,"port0","%s" % self.dut.ports_info[0]['pci']) > + self.replace_pci(parent + filename,"port1","%s" % self.dut.ports_info[1]['pci']) > + self.replace_pci(parent + filename,"port2","%s" % self.dut.ports_info[2]['pci']) > + self.replace_pci(parent + filename,"port3","%s" % self.dut.ports_info[3]['pci']) If this suite required at least four ports, please check the number in set_up_all function. > + rootdir = "dep/ip_pipeline/ip_pipeline_link_identification/negative/" > + for parent,dirnames,filenames in os.walk(rootdir): > + for filename in filenames: > + self.replace_pci(parent + filename,"port0","%s" % self.dut.ports_info[0]['pci']) > + self.replace_pci(parent + filename,"port1","%s" % self.dut.ports_info[1]['pci']) > + self.replace_pci(parent + filename,"port2","%s" % self.dut.ports_info[2]['pci']) > + self.replace_pci(parent + filename,"port3","%s" % self.dut.ports_info[3]['pci']) > + self.tester.send_expect("cd dep/","#",10) > + self.tester.send_expect("rm -rf ip_pipeline.tar.gz","#",10) > + self.tester.send_expect("tar -czvf ip_pipeline.tar.gz ip_pipeline/","#",10) > + self.tester.send_expect("cd ../","#",10) > + > + > + def test_postive(self): > + rootdir = "dep/ip_pipeline/ip_pipeline_link_identification/postive/" > + for parent,dirnames,filenames in os.walk(rootdir): > + for filename in filenames: > + if "_f" in filename: > + cmd = self.path + " -f ~/ip_pipeline/ip_pipeline_link_identification/postive/%s" % filename > + self.dut.send_expect(cmd,"[PIPELINE1]",50) > + out = self.dut.send_expect("quit","# ",10) > + self.verify("Bye!" in out, "Test failed on %s" % filename) > + elif "_pf" in filename: > + cmd = self.path + " -p f -f ~/ip_pipeline/ip_pipeline_link_identification/postive/%s" % filename > + self.dut.send_expect(cmd,"[PIPELINE1]",50) > + out = self.dut.send_expect("quit","# ",10) > + self.verify("Bye!" in out, "Test failed on %s" % filename) > + > + > + def test_negative(self): > + rootdir = "dep/ip_pipeline/ip_pipeline_link_identification/negative/" > + for parent,dirnames,filenames in os.walk(rootdir): > + for filename in filenames: > + if "_f" in filename: > + cmd = self.path + " -p 0x3 -f ~/ip_pipeline/ip_pipeline_link_identification/negative/%s" % filename > + out = self.dut.send_expect(cmd,"# ",50) > + self.verify("error" in out, "Test failed on %s" % filename) > + elif "_1p" in filename: > + cmd = self.path + " -p 1 -f ~/ip_pipeline/ip_pipeline_link_identification/negative/%s" % filename > + out = self.dut.send_expect(cmd,"# ",50) > + self.verify("error" in out, "Test failed on %s" % filename) > + > + elif "_3p" in filename: > + cmd = self.path + " -p 3 -f ~/ip_pipeline/ip_pipeline_link_identification/negative/%s" % filename > + out = self.dut.send_expect(cmd,"#",50) > + self.verify("error" in out, "Test failed on %s" % filename) > + > + > + def tear_down(self): > + """ > + Run after each test case. > + """ > + self.dut.kill_all() > + time.sleep(2) > + > + def tear_down_all(self): > + """ > + Run after each test suite. > + """ > + pass