test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V2] fix nvgre packet type detection case
Date: Thu, 25 Aug 2016 13:53:23 +0800	[thread overview]
Message-ID: <57BE87D3.5040108@intel.com> (raw)
In-Reply-To: <1472089353-28781-1-git-send-email-huilongx.xu@intel.com>

Thanks, huilong. Applied.

On 08/25/2016 09:42 AM, xu,huilong wrote:
> nvgre packet type detection must use without VEC PMD
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_nvgre.py | 26 +++++++++++++++++++++++---
>   1 file changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py
> index 1da551b..bcbf41b 100644
> --- a/tests/TestSuite_nvgre.py
> +++ b/tests/TestSuite_nvgre.py
> @@ -349,7 +349,12 @@ class TestNvgre(TestCase):
>           nvgre Prerequisites
>           """
>           # this feature only enable in FVL now
> -        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortpark_TLV", "sageville", "sagepond"], "NVGRE Only supported by Fortville and Sageville")
> +        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortpark_TLV"]:
> +            self.compile_switch = 'CONFIG_RTE_LIBRTE_I40E_INC_VECTOR'
> +        elif self.nic in ["sageville", "sagepond"]:
> +            self.compile_switch = 'CONFIG_RTE_IXGBE_INC_VECTOR'
> +        else:
> +            self.verify(False, "%s not support NVGRE case" % self.nic)
>           # Based on h/w type, choose how many ports to use
>           ports = self.dut.get_ports(self.nic)
>           self.portmask = dts.create_mask(self.dut.get_ports(self.nic))
> @@ -457,7 +462,7 @@ class TestNvgre(TestCase):
>           self.dut.send_expect("show port stats all", "testpmd>", 10)
>           self.dut.send_expect("stop", "testpmd>", 10)
>           self.dut.send_expect("quit", "#", 10)
> -
> +
>       def nvgre_filter(self, filter_type="omac-imac-tenid", queue_id=3, vlan=False, remove=False):
>           """
>           send nvgre packet and check whether receive packet in assigned queue
> @@ -602,6 +607,15 @@ class TestNvgre(TestCase):
>           """
>           verify nvgre packet with ipv4
>           """
> +        # packet type detect must used without VECTOR pmd
> +        out = self.dut.send_expect("cat config/common_base", "]# ", 10)
> +        src_vec_model = re.findall("%s=." % self.compile_switch, out)[0][-1]
> +        if src_vec_model == 'y':
> +            self.dut.send_expect("sed -i -e 's/%s=.*$/" % self.compile_switch
> +                                + "%s=n/' config/common_base" % self.compile_switch, "# ", 30)
> +            self.dut.skip_setup = False
> +            self.dut.build_install_dpdk(self.target)
> +
>           # check no nvgre packet
>           self.nvgre_detect(outer_ip_proto=0xFF)
>           # check nvgre + IP inner packet
> @@ -614,7 +628,13 @@ class TestNvgre(TestCase):
>           self.nvgre_detect(outer_vlan=1)
>           # check vlan nvgre + vlan inner packet
>           self.nvgre_detect(outer_vlan=1, inner_vlan=1)
> -
> +        out = self.dut.send_expect("cat config/common_base", "]# ", 10)
> +        dst_vec_model = re.findall("%s=." % self.compile_switch, out)[0][-1]
> +        if src_vec_model != dst_vec_model:
> +            self.dut.send_expect("sed -i -e 's/%s=.*$/" % self.compile_switch
> +                                + "%s=%s/' config/common_base" % (self.compile_switch, src_vec_model), "# ", 30)
> +            self.dut.skip_setup = False
> +            self.dut.build_install_dpdk(self.target)
>       def test_tunnel_filter(self):
>   
>           # verify tunnel filter feature

      reply	other threads:[~2016-08-25  5:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  1:42 xu,huilong
2016-08-25  5:53 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57BE87D3.5040108@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).