test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] fix vxlan failed case
Date: Thu, 25 Aug 2016 14:09:09 +0800	[thread overview]
Message-ID: <57BE8B85.3090708@intel.com> (raw)
In-Reply-To: <1472021516-27491-1-git-send-email-huilongx.xu@intel.com>

Thanks huilong, two comments.
1. no need to change the setting in all cases. Only one time in 
set_up_all is enough.
2. Nvgre patch has been merged, please send out patch only for vxlan suite.

On 08/24/2016 02:51 PM, xu,huilong wrote:
>       def test_vxlan_ipv6_detect(self):
>           """
>           verify vxlan packet detection with ipv6 header
>           """
> +        out = self.dut.send_expect("cat config/common_base", "]# ", 10)
> +        src_vec_model = re.findall("%s=." % self.compile_switch, out)[0][-1]
> +        if src_vec_model == 'y':
> +            self.dut.send_expect("sed -i -e 's/%s=.*$/" % self.compile_switch
> +                                + "%s=n/' config/common_base" % self.compile_switch, "# ", 30)
> +            self.dut.skip_setup = False
> +            self.dut.build_install_dpdk(self.target)
> +
>           pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
>               "%(CHANNEL)d -- -i --disable-rss --rxq=4 --txq=4" + \
>               " --nb-cores=4 --portmask=%(PORT)s --txqflags=0x0"
> @@ -596,6 +624,14 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>           out = self.dut.send_expect("stop", "testpmd>", 10)
>           self.dut.send_expect("quit", "#", 10)
>   
> +        out = self.dut.send_expect("cat config/common_base", "]# ", 10)
> +        dst_vec_model = re.findall("%s=." % self.compile_switch, out)[0][-1]
> +        if src_vec_model != dst_vec_model:
> +            self.dut.send_expect("sed -i -e 's/%s=.*$/" % self.compile_switch
> +                                + "%s=%s/' config/common_base" % (self.compile_switch, src_vec_model), "# ", 30)
> +            self.dut.skip_setup = False
> +            self.dut.build_install_dpdk(self.target)
> +
>       def test_vxlan_ipv4_checksum_offload(self):
>           """
>           verify vxlan packet checksum offload
> -- 1.9.3

  reply	other threads:[~2016-08-25  6:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24  6:51 xu,huilong
2016-08-25  6:09 ` Liu, Yong [this message]
2016-08-25  6:42   ` Xu, HuilongX
2016-08-25  7:00     ` Liu, Yong
2016-08-25  7:09       ` Xu, HuilongX
2016-09-08  8:04         ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57BE8B85.3090708@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).