From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 3189858CB
 for <dts@dpdk.org>; Thu, 25 Aug 2016 08:05:36 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga105.jf.intel.com with ESMTP; 24 Aug 2016 23:05:35 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,574,1464678000"; d="scan'208";a="1041177975"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by orsmga002.jf.intel.com with ESMTP; 24 Aug 2016 23:05:34 -0700
Message-ID: <57BE8B85.3090708@intel.com>
Date: Thu, 25 Aug 2016 14:09:09 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
References: <1472021516-27491-1-git-send-email-huilongx.xu@intel.com>
In-Reply-To: <1472021516-27491-1-git-send-email-huilongx.xu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH V1] fix vxlan failed case
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Aug 2016 06:05:36 -0000

Thanks huilong, two comments.
1. no need to change the setting in all cases. Only one time in 
set_up_all is enough.
2. Nvgre patch has been merged, please send out patch only for vxlan suite.

On 08/24/2016 02:51 PM, xu,huilong wrote:
>       def test_vxlan_ipv6_detect(self):
>           """
>           verify vxlan packet detection with ipv6 header
>           """
> +        out = self.dut.send_expect("cat config/common_base", "]# ", 10)
> +        src_vec_model = re.findall("%s=." % self.compile_switch, out)[0][-1]
> +        if src_vec_model == 'y':
> +            self.dut.send_expect("sed -i -e 's/%s=.*$/" % self.compile_switch
> +                                + "%s=n/' config/common_base" % self.compile_switch, "# ", 30)
> +            self.dut.skip_setup = False
> +            self.dut.build_install_dpdk(self.target)
> +
>           pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
>               "%(CHANNEL)d -- -i --disable-rss --rxq=4 --txq=4" + \
>               " --nb-cores=4 --portmask=%(PORT)s --txqflags=0x0"
> @@ -596,6 +624,14 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>           out = self.dut.send_expect("stop", "testpmd>", 10)
>           self.dut.send_expect("quit", "#", 10)
>   
> +        out = self.dut.send_expect("cat config/common_base", "]# ", 10)
> +        dst_vec_model = re.findall("%s=." % self.compile_switch, out)[0][-1]
> +        if src_vec_model != dst_vec_model:
> +            self.dut.send_expect("sed -i -e 's/%s=.*$/" % self.compile_switch
> +                                + "%s=%s/' config/common_base" % (self.compile_switch, src_vec_model), "# ", 30)
> +            self.dut.skip_setup = False
> +            self.dut.build_install_dpdk(self.target)
> +
>       def test_vxlan_ipv4_checksum_offload(self):
>           """
>           verify vxlan packet checksum offload
> -- 1.9.3